Date: Sat, 14 May 2016 16:46:09 +0200 From: Hans Petter Selasky <hps@selasky.org> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r299653 - head/sys/compat/linuxkpi/common/include/linux Message-ID: <c5514a72-1632-99bd-4dde-975830604c06@selasky.org> In-Reply-To: <1651080.VgjHNWYnll@ralph.baldwin.cx> References: <201605131010.u4DAAioY094617@repo.freebsd.org> <1651080.VgjHNWYnll@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On 05/13/16 20:43, John Baldwin wrote: > On Friday, May 13, 2016 10:10:44 AM Hans Petter Selasky wrote: >> @@ -190,6 +258,7 @@ >> #define smp_processor_id() PCPU_GET(cpuid) >> #define num_possible_cpus() mp_ncpus >> #define num_online_cpus() mp_ncpus >> +#define cpu_has_clflush (1) > > This is only true on amd64. More accurate would be: > > #ifdef __amd64__ > #define cpu_has_clflush (1) > #elif defined(__i386__) > #define cpu_has_clflush (cpu_feature & CPUID_CLFSH) > #else > #define cpu_has_clflush clflush_not_supported > #endif > > Presumably you aren't planning to restrict all of OFED and drm2 to only > be used on amd64? > I'll handle this on Monday. Thank you for your patch! --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c5514a72-1632-99bd-4dde-975830604c06>