Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 11 Sep 2000 20:04:58 +0300
From:      Maxim Sobolev <sobomax@FreeBSD.org>
To:        Steve Price <sprice@hiwaay.net>
Cc:        ports@FreeBSD.org, asami@FreeBSD.org
Subject:   Re: Handling of symlinks to directory in pkg_delete [patch for review]
Message-ID:  <39BD10BA.8435B6B1@FreeBSD.org>
References:  <39B351FA.A6CFD24F@FreeBSD.org> <20000909160721.B2089@bonsai.hiwaay.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Steve Price wrote:

> On Mon, Sep 04, 2000 at 10:40:42AM +0300, Maxim Sobolev wrote:
> # Hi!
> #
> # I wonder if anybody noticed that handling of symlinks in pkg_delete is somewhat
> # broken. Particularly, the problems exist with symlinks to a directories. The
> # pkg_delete code considers those symlinks as a directories (if the referred
> # directory exists), however they are not, and thus tries to delete it using
> # rmdir(2), which obviously doesn't work. The workaround exists to delete
> # directory symlink points to first and only then remove corresponding symlinks,
> # however it looks like an ugly hack (see lesstif's PLIST for example). The
> # attached patch is expected to solve this problem. Also in this message I'm
> # attaching small fake package, which exposes the bug (it consist of one symlink
> # and one directory this symlink points to).
>
> [patch elided]
>
> Looks good to me.  You might want to fix the style(9) in the new
> issymlink function.  It would also be nice if along with this change
> you hunted down and fixed all the PLISTs that have rmdir hacks that
> are no longer required.  I can test some of them for you if want.
> Better yet you could probably just submit patches to Satoshi and let
> the new package building cluster test your changes for you.

Satoshi,

Can you test this patch on your build cluster? It should be fully backward
compatible.

-Maxim



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?39BD10BA.8435B6B1>