From owner-freebsd-ports Mon Sep 11 10: 9:44 2000 Delivered-To: freebsd-ports@freebsd.org Received: from blizzard.sabbo.net (blizzard.sabbo.net [193.193.218.18]) by hub.freebsd.org (Postfix) with ESMTP id 3D2D537B424; Mon, 11 Sep 2000 10:09:32 -0700 (PDT) Received: from vic.sabbo.net (root@[193.193.218.95]) by blizzard.sabbo.net (8.9.1/8.9.3) with ESMTP id UAA25772; Mon, 11 Sep 2000 20:09:24 +0300 (EEST) Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vic.sabbo.net (8.11.0/8.9.3) with ESMTP id e8BH52W13830; Mon, 11 Sep 2000 20:05:02 +0300 (EEST) (envelope-from sobomax@FreeBSD.org) Message-ID: <39BD10BA.8435B6B1@FreeBSD.org> Date: Mon, 11 Sep 2000 20:04:58 +0300 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.75 [en] (WinNT; U) X-Accept-Language: uk,ru,en MIME-Version: 1.0 To: Steve Price Cc: ports@FreeBSD.org, asami@FreeBSD.org Subject: Re: Handling of symlinks to directory in pkg_delete [patch for review] References: <39B351FA.A6CFD24F@FreeBSD.org> <20000909160721.B2089@bonsai.hiwaay.net> Content-Type: text/plain; charset=x-user-defined Content-Transfer-Encoding: 7bit Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Steve Price wrote: > On Mon, Sep 04, 2000 at 10:40:42AM +0300, Maxim Sobolev wrote: > # Hi! > # > # I wonder if anybody noticed that handling of symlinks in pkg_delete is somewhat > # broken. Particularly, the problems exist with symlinks to a directories. The > # pkg_delete code considers those symlinks as a directories (if the referred > # directory exists), however they are not, and thus tries to delete it using > # rmdir(2), which obviously doesn't work. The workaround exists to delete > # directory symlink points to first and only then remove corresponding symlinks, > # however it looks like an ugly hack (see lesstif's PLIST for example). The > # attached patch is expected to solve this problem. Also in this message I'm > # attaching small fake package, which exposes the bug (it consist of one symlink > # and one directory this symlink points to). > > [patch elided] > > Looks good to me. You might want to fix the style(9) in the new > issymlink function. It would also be nice if along with this change > you hunted down and fixed all the PLISTs that have rmdir hacks that > are no longer required. I can test some of them for you if want. > Better yet you could probably just submit patches to Satoshi and let > the new package building cluster test your changes for you. Satoshi, Can you test this patch on your build cluster? It should be fully backward compatible. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message