From owner-freebsd-current@FreeBSD.ORG Thu May 14 15:01:43 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4D09A6B5 for ; Thu, 14 May 2015 15:01:43 +0000 (UTC) Received: from elvis.mu.org (elvis.mu.org [IPv6:2001:470:1f05:b76::196]) by mx1.freebsd.org (Postfix) with ESMTP id 36FC5167C for ; Thu, 14 May 2015 15:01:43 +0000 (UTC) Received: from AlfredMacbookAir.local (c-76-21-10-192.hsd1.ca.comcast.net [76.21.10.192]) by elvis.mu.org (Postfix) with ESMTPSA id 1E2D8341F810 for ; Thu, 14 May 2015 08:01:43 -0700 (PDT) Message-ID: <5554B8D6.1010705@mu.org> Date: Thu, 14 May 2015 08:01:42 -0700 From: Alfred Perlstein User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: freebsd-current@freebsd.org Subject: Re: Increase BUFSIZ to 8192 References: <14994.1431412293@critter.freebsd.dk> <20150513080342.GE37063@funkthat.com> <55530CC3.1090204@selasky.org> <1431528249.1221.15.camel@freebsd.org> <20150513181347.GM37063@funkthat.com> <1431542835.1221.30.camel@freebsd.org> <20150514072155.GT37063@funkthat.com> <62511.1431589335@critter.freebsd.dk> <20150514075316.GY37063@funkthat.com> <77887.1431590789@critter.freebsd.dk> <6AE8973B-3C03-497F-85A9-96C4D464B4BD@gmail.com> In-Reply-To: <6AE8973B-3C03-497F-85A9-96C4D464B4BD@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2015 15:01:43 -0000 On 5/14/15 2:23 AM, Garrett Cooper wrote: > On May 14, 2015, at 1:06, Poul-Henning Kamp wrote: > >> -------- >> In message <20150514075316.GY37063@funkthat.com>, John-Mark Gurney writes: >>> Poul-Henning Kamp wrote this message on Thu, May 14, 2015 at 07:42 +0000: >>>> -------- >>>> In message <20150514072155.GT37063@funkthat.com>, John-Mark Gurney writes: >>>> >>>>> Since you apprently missed my original reply, I said that we shouldn't >>>>> abuse BUFSIZ for this work, and that it should be changed in mdXhl.c... >>>> Say what ? >>>> >>>> BUFSIZ is used entirely appropriately in MDXFileChunk(): For reading >>>> a file into an algorithm. >>> In fact, posix-2008 references LINE_MAX because: >> MDXFileChunk() does not read lines, it reads an entire file. > Being pedantic, technically it’s a portion of a file, which can be the whole thing, and it reads it in “sizeof(buffer)” chunks (of which buffer is “hardcoded" to BUFSIZ right now). > Cheers! Shouldn't most of these be using st.st_blksize ? I recall being part of the move to get rid of PAGE_SIZE, perhaps many places should be rid of BUFSIZE as well and BUFSIZE should be something we query the system for. -Alfred