Date: Sun, 22 Jul 2018 21:40:56 +0200 (CEST) From: Gerald Pfeifer <gerald@pfeifer.com> To: Mathieu Arnold <mat@FreeBSD.org>, Eitan Adler <eadler@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r474870 - head/Mk Message-ID: <alpine.LSU.2.21.1807222137060.9128@anthias.pfeifer.com> In-Reply-To: <201807181508.w6IF8ino036717@repo.freebsd.org> References: <201807181508.w6IF8ino036717@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Mat, On Wed, 18 Jul 2018, Mathieu Arnold wrote: > URL: https://svnweb.freebsd.org/changeset/ports/474870 > > Log: > Fix copy&paste error. this is one of the examples I've seen in our tree where doing an `svn log` a year from now it's going to be hard to see what's going on. A bit more context would be nice. While we are at it, okay to commit the patch below which fixes the grammar of informational message in four cases? Gerald Index: Mk/bsd.licenses.mk =================================================================== --- Mk/bsd.licenses.mk (revision 475117) +++ Mk/bsd.licenses.mk (working copy) @@ -581,22 +581,22 @@ .if ${_LICENSE_PERMS:Mdist-mirror} @${ECHO_MSG} "===> License allows mirroring distribution files" .else - @${ECHO_MSG} "===> License does not allows mirroring distribution files" + @${ECHO_MSG} "===> License does not allow mirroring distribution files" .endif .if ${_LICENSE_PERMS:Mdist-sell} @${ECHO_MSG} "===> License allows selling distribution files" .else - @${ECHO_MSG} "===> License does not allows selling distribution files" + @${ECHO_MSG} "===> License does not allow selling distribution files" .endif .if ${_LICENSE_PERMS:Mpkg-mirror} @${ECHO_MSG} "===> License allows mirroring pre-built packages" .else - @${ECHO_MSG} "===> License does not allows mirroring pre-build packages" + @${ECHO_MSG} "===> License does not allow mirroring pre-build packages" .endif .if ${_LICENSE_PERMS:Mpkg-sell} @${ECHO_MSG} "===> License allows selling pre-build packages" .else - @${ECHO_MSG} "===> License does not allows selling pre-build packages" + @${ECHO_MSG} "===> License does not allow selling pre-build packages" .endif .if ${_LICENSE_PERMS:Mauto-accept} @${ECHO_MSG} "===> License allows being auto-accepted"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.21.1807222137060.9128>