Date: Thu, 15 Nov 2007 13:08:03 -0700 From: Scott Long <scottl@samsco.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Gleb Smirnoff <glebius@FreeBSD.org>, Julian Elischer <julian@elischer.org>, Steve Kargl <sgk@troutmask.apl.washington.edu> Subject: Re: cvs commit: src/sys/kern kern_kse.c Message-ID: <473CA723.9000409@samsco.org> In-Reply-To: <20071115194710.L82897@fledge.watson.org> References: <200711151416.lAFEGKJ6059040@repoman.freebsd.org> <473C865D.8070809@elischer.org> <20071115181401.GA17094@troutmask.apl.washington.edu> <473C901F.1080906@elischer.org> <20071115194710.L82897@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Robert Watson wrote: > > On Thu, 15 Nov 2007, Julian Elischer wrote: > >>>> "no matter how small the change, use diff + patch to move it across." >>> >>> After applying the patch on your commit machine, is it too difficult >>> to actually retest before committing? This would catch the broken >>> commit before it becomes a Tinderbox issue. >>> >>> Seems to be a QA problem on your part. >> >> yes.. but I can't do a compile from my mac. (my commit machine). The >> answer is to be rigorous about how I move the patch from the build >> machine to the commit machine. >> >> This is a temporary situation. new infrastructure will let me commit >> from my build machine again. > > I find having a copy of Parallels (or VMWare) around very useful for > precisely this situation -- it means that even when I have only the Mac > around I can easily do a local test build. The various VM packages > certainly have their limitations, but they're far better than nothing. > And to be fair, there are habitual build breakers and there are non-habitual build breakers. Julian, IMHO, falls mostly into the latter category, yet I see people focus on him disproportionally. Funny. Kinda. Not. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?473CA723.9000409>