Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 12 Oct 2002 19:17:09 -0700
From:      Luigi Rizzo <rizzo@icir.org>
To:        "M. Warner Losh" <imp@bsdimp.com>
Cc:        net@FreeBSD.ORG
Subject:   Re: Comments Please
Message-ID:  <20021012191709.B93684@carp.icir.org>
In-Reply-To: <20021012.200747.59843102.imp@bsdimp.com>; from imp@bsdimp.com on Sat, Oct 12, 2002 at 08:07:47PM -0600
References:  <20021012.171809.93306957.imp@bsdimp.com> <20021012171339.A92744@carp.icir.org> <20021012.200747.59843102.imp@bsdimp.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 12, 2002 at 08:07:47PM -0600, M. Warner Losh wrote:
...
> :     reveals the use of an explicit constant (6) in net/if_arp.h and
> :     netinet/if_ether.c; there is more of the same in net/bridge.c
> :     (my fault), net/if_atmsubr.c, netinet/if_ether.c, netncp/ncp_subr.c
> 
> atmsubr?  Doesn't ATM have its own constants?

eh, that's the problem with explicit constants, you can never tell
whether "6" is english, german or italian... in any case the
relevant piece of code is:

	net/if_atmsubr.c:                       if (bcmp(alc, ATMLLC_HDR, 6)) {

I have no idea if it has any relation with ethernet header sizes.

	cheers
	luigi

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021012191709.B93684>