From owner-freebsd-net@FreeBSD.ORG  Sat Jun 26 21:00:17 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 30133106567D
	for <freebsd-net@hub.freebsd.org>; Sat, 26 Jun 2010 21:00:17 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id E40D18FC16
	for <freebsd-net@hub.freebsd.org>; Sat, 26 Jun 2010 21:00:16 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o5QL0Gio078893
	for <freebsd-net@freefall.freebsd.org>; Sat, 26 Jun 2010 21:00:16 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o5QL0GNO078892;
	Sat, 26 Jun 2010 21:00:16 GMT (envelope-from gnats)
Date: Sat, 26 Jun 2010 21:00:16 GMT
Message-Id: <201006262100.o5QL0GNO078892@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: Rui Paulo <rpaulo@FreeBSD.org>
Cc: 
Subject: Re: kern/146517: [ath] [wlan] device timeouts for ath wlan device
	on recent stable.
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Rui Paulo <rpaulo@FreeBSD.org>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Jun 2010 21:00:17 -0000

The following reply was made to PR kern/146517; it has been noted by GNATS.

From: Rui Paulo <rpaulo@FreeBSD.org>
To: Rui Paulo <rpaulo@freebsd.org>
Cc: Alex Kozlov <spam@rm-rf.kiev.ua>,
 bug-followup@FreeBSD.org,
 vince@unsane.co.uk
Subject: Re: kern/146517: [ath] [wlan] device timeouts for ath wlan device on recent stable.
Date: Sat, 26 Jun 2010 21:58:03 +0100

 On 26 Jun 2010, at 21:52, Rui Paulo wrote:
 
 > 
 > On 22 Jun 2010, at 14:35, Alex Kozlov wrote:
 > 
 >> On Mon, Jun 21, 2010 at 05:30:30PM +0100, Rui Paulo wrote:
 >>> On 21 Jun 2010, at 15:38, Alex Kozlov wrote:
 >>>> On Mon, May 31, 2010 at 07:30:04PM +0000, Rui Paulo wrote:
 >>>>>> I confirm this. Atheros 9280, work fine with 8.0R usb stick,
 >>>>>> timeout after few pings with 8.1-BETA1.
 >>>>>> I can try to find a particular commit, that causes this
 >>>>>> regression, if its help.
 >>>>> Yes, please.
 >>>> Sorry for the delay. I think that the culprit is r203959.
 >>> Please try this patch.
 >> Patch does not help, but if I change line in AR_SREV_MERLIN_20 from
 >> AH_PRIVATE((_ah))->ah_macRev == AR_XSREV_REVISION_MERLIN_20
 >> to
 >> AH_PRIVATE((_ah))->ah_macRev >= AR_XSREV_REVISION_MERLIN_20
 >> net works again.
 > 
 > I think this is the correct version. Can you try?
 > 
 > Index: ar5416/ar5416reg.h
 > ===================================================================
 > --- ar5416/ar5416reg.h	(revision 209522)
 > +++ ar5416/ar5416reg.h	(working copy)
 > @@ -611,8 +611,8 @@
 > 	(AR_SREV_MERLIN(_ah) && \
 > 	 AH_PRIVATE((_ah))->ah_macRev == AR_XSREV_REVISION_MERLIN_20)
 > #define	AR_SREV_MERLIN_20_OR_LATER(_ah) \
 > -	(AR_SREV_MERLIN_20(_ah) || \
 > -	 AH_PRIVATE((_ah))->ah_macVersion > AR_XSREV_VERSION_MERLIN)
 > +	(AR_SREV_MERLIN(_ah) || \
 > +	 AH_PRIVATE((_ah))->ah_macVersion >= AR_XSREV_VERSION_MERLIN_20)
 > 
 > #define	AR_SREV_KITE(_ah) \
 > 	(AH_PRIVATE((_ah))->ah_macVersion == AR_XSREV_VERSION_KITE)
 
 Actually, forget this. You were right. I'll commit your fix.
 
 Thanks,
 --
 Rui Paulo