Date: Sat, 14 Apr 2018 10:45:29 -0300 From: Joseph Mingrone <jrm@FreeBSD.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: Matthias Fechner <idefix@fechner.net>, Alexey Dokuchaev <danfe@freebsd.org>, Torsten Zuehlsdorff <freebsd@toco-domains.de>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r467193 - in head/www/gitlab: . files Message-ID: <864lkdlx52.fsf@phe.ftfl.ca> In-Reply-To: <CAMHz58S8H%2BV7cPY90-vZX94iS7JwRWpk0bSFbLncagfdpUxKnw@mail.gmail.com> (Sunpoet Po-Chuan Hsieh's message of "Sat, 14 Apr 2018 04:13:00 %2B0800") References: <201804121833.w3CIXtgW077267@repo.freebsd.org> <e1a55c7b-1ad1-36c8-ec3d-f806702feed5@fechner.net> <CAMHz58RD9rtyqBLV6nsZ2naOvGRiO7PDPAGWZ8Vemnz-g1J6cw@mail.gmail.com> <431aaec9-51c2-c0c9-7a1f-2f29f79edb5d@fechner.net> <20180413100736.GA32041@FreeBSD.org> <b14f8ea5-5d26-6ea0-c175-558a8fef2504@toco-domains.de> <86o9inrzzk.fsf@phe.ftfl.ca> <CAMHz58S8H%2BV7cPY90-vZX94iS7JwRWpk0bSFbLncagfdpUxKnw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> writes: > On Fri, Apr 13, 2018 at 9:35 PM, Joseph Mingrone <jrm@freebsd.org> wrote: >> Matthias Fechner <idefix@fechner.net> writes: >> > Dear sunpoet, >> > Am 12.04.2018 um 20:33 schrieb Sunpoet Po-Chuan Hsieh: >> >> Log: >> >> Fix Gemfile for rubygem-default_value_for 3.1.0 update >> >> - Bump PORTREVISION for package change >> >> Modified: >> >> head/www/gitlab/Makefile >> >> head/www/gitlab/files/patch-Gemfile >> > I really enjoy your work and it is totally fine for me, if you upgrade= a >> > gem that you copy the old one and make sure that gitlab uses the old. >> > (like you did with r467106, thanks a lot for this!) >> > But please do not start to patch the Gemfile! >> > This will break gitlab. Have you tested gitlab with this modification? >> > (for sure not, I reported exactly that version of default_value_for >> > upstream and they rolled back the change as it broke gitlab, they broke >> > 3.0.4 and rolled back the modification with 3.0.5, now you changed >> > gitlab to use the version that for sure will not work!) >> > Please revert this modification and ask me (the maintainer) before you >> > start to modify the port I maintain. >> > Thanks a lot that you understand this. >> > Gru=C3=9F >> > Matthias >> I relate. Sunpoet, I also appreciate your work, but this type of >> breakage can be frustrating. We need to figure out a solution. > Hi, > As I replied before, I'll keep the Gemfile unchanged. > The rubygem ports will follow the version requirement in Gemfile. > In fact, I stored the Gemfiles of gitlab, mastodon and vagrant in a > specific directory. > When I update a rubygem port, I check the dependent ports to see if they > accepts the newer version. > Regards, > sunpoet Thank you. For the past while Gem updates have been smooth for net-im/mast= odon. J. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEVbCTpybDiFVxIrrVNqQMg7DW754FAlrSBflfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUACgkQNqQMg7DW 755FhxAApak/7Dt+tuYcsMQX5nIF9Y1iqoRH58FhU/48LwsFy04QdCvftRBTi8lV SxlaUZ8D3xGPh8h2QB/AjJuEM3SZ1VpIrM0h6KDfln2TBPmKBBmnP2mikDmgDX/a LYPiuiMFRLBnZUfZi3w8K7PrpaREb6wx4m8nK20Q90qTixZfe6jD91ynYvBNU1E6 PIpuAlChOXHtFkfMUw+d49ZVPZvjJSvAM88inyd5jbW9LlgNz61VVA/mQ666Z08E YoMqUHdzgGepCrr2Ya9QnGfJqPsm1UjduxYHri16FPMH+zM/1A3IO+0ksUbda8d2 wEWxesPkFnoc5AHTP6jcV6vDkaVQI8EoxOYxJ+3s2Ju+fvTztDXcVrYR4Qxq3VhQ JW8aDu81vfmmOn7MAnKT4pxg1Fa9H01iJ1K1oH0qYjLFR2qObr+6Mhr0vaKXcZuU DXS3hSfgryC2iaYTiagBtAd6Qk9bkCJidnTGeUItG3PEVwn2aWT+WjPVR+xTL4gV GJt37jSel5Jk65GO1HMVa2N6MEg1LvfRVDaR7hUGb+e2vyRtrWKrIiIl41SqQm8O UG3rwIYMa4U1jm+NW+E8f6ChDPnXR+K5meAiu2J0r63HOgAv/J0b0RO6fY6UXrK2 +GzwSjTlZnjyCVtOL0rf20+GAlxvLBBrXV8kcgo9CIRsiSxtlFU= =rVKs -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?864lkdlx52.fsf>