Date: Fri, 17 Jan 2014 23:42:29 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Max Brazhnikov <makc@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Alexander Leidinger <netchild@freebsd.org>, ports-committers@freebsd.org Subject: Re: svn commit: r340118 - head/audio/lame Message-ID: <20140117224229.GA78580@ithaqua.etoilebsd.net> In-Reply-To: <5844234.U6fZ9grvn7@mercury.ph.man.ac.uk> References: <201401172141.s0HLfCP0096620@svn.freebsd.org> <5844234.U6fZ9grvn7@mercury.ph.man.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
--tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 17, 2014 at 10:29:57PM +0000, Max Brazhnikov wrote: > On Fri, 17 Jan 2014 21:41:12 +0000Fri Jan 17 21:41:12 2014 Alexander Leid= inger wrote: > > Author: netchild > > Date: Fri Jan 17 21:41:12 2014 > > New Revision: 340118 > > URL: http://svnweb.freebsd.org/changeset/ports/340118 > > QAT: https://qat.redports.org/buildarchive/r340118/ > >=20 > > Log: > > support stagedir > > =20 > > PR: 185565 > > Submitted by: Takefu <takefu@airport.fm> > >=20 > > Modified: > > head/audio/lame/Makefile > > head/audio/lame/pkg-plist > >=20 > > Modified: head/audio/lame/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/audio/lame/Makefile Fri Jan 17 21:38:50 2014 (r340117) > > +++ head/audio/lame/Makefile Fri Jan 17 21:41:12 2014 (r340118) > > @@ -11,16 +11,14 @@ MAINTAINER=3D netchild@FreeBSD.org > > COMMENT=3D Fast MP3 encoder kit > > =20 > > USES=3D gmake iconv > > -NO_STAGE=3D yes > > USE_AUTOTOOLS=3D libtool > > USE_LDCONFIG=3D yes > > GNU_CONFIGURE=3D yes > > CONFIGURE_ARGS=3D --enable-nasm --enable-mp3rtp --disable-gtktest > > +CONFIGURE_ARGS_PREFIX=3D ${STAGEDIR}${PREFIX} >=20 > What's this?! Does it really do anything? >=20 No it doesn't at all :) btw here is a patch to cleanup a bit that port: http://people.freebsd.org/~bapt/lame.diff it removes the noop "CONFIGURE_ARGS_PREFIX=3D ${STAGEDIR}${PREFIX}" let the standard gmake install install everything, decomposing seems to bri= ng nothing more (no extra files installed or file missing) Strip the binary library (DEVELOPER=3Dyes passes thought stage-qa target wh= ich shows that is it not stripped) Always install the doc in the stage dir and let stage properly decided if it will be install or not. regards, Bapt --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLZsdUACgkQ8kTtMUmk6EyIaQCcD91fvN4THKTdV7niCfYzVTfa Yf0AnA/GOjyEihlCJptELLocArh8jEAp =dsBt -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140117224229.GA78580>