Date: Sun, 4 Nov 2018 14:35:05 +0100 From: Emanuel Haupt <ehaupt@FreeBSD.org> To: Gerald Pfeifer <gerald@pfeifer.com>, Rene Ladan <rene@FreeBSD.org>, Michael Reifenberger <mr@FreeBSD.org>, Steve Wills <swills@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r483807 - in head: Mk Mk/Uses audio/kwave audio/logitechmediaserver audio/supercollider audio/teamspeak3-server audio/wavpack audio/zynaddsubfx base/binutils cad/calculix cad/linuxcnc-d... Message-ID: <73aa348d-ef4b-b4ce-5f89-fc415d9138a5@FreeBSD.org> In-Reply-To: <alpine.LSU.2.21.1811031311210.15730@anthias.pfeifer.com> References: <201811021332.wA2DWZPm025383@repo.freebsd.org> <alpine.LSU.2.21.1811031311210.15730@anthias.pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/3/18 1:22 PM, Gerald Pfeifer wrote: > On Fri, 2 Nov 2018, Rene Ladan wrote: >> URL: https://svnweb.freebsd.org/changeset/ports/483807 >> >> Log: >> Remove compatibility code for FreeBSD < 11.2 from all ports. >> >> Simplify some ports where DragonFlyBSD no longer needs to be special-cased. >> Submitted by: rene >> Reviewed by: bapt, jbeich >> Differential Revision: https://reviews.freebsd.org/D17724 > >> Modified: head/cad/openscad/Makefile >> ============================================================================== >> -#.if ${ARCH} == i386 && ${OSVERSION} >= 1100000 >> +#.if ${ARCH} == i386 >> #USE_GCC= yes >> #.endif > > Yes, but this was dead code before and is still dead code. > > Okay to remove this, Michael? > >> Modified: head/devel/heimdall/Makefile >> ============================================================================== >> # does not compile with clang 6.0.0 >> -.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1101513 >> +.if ${OPSYS} == FreeBSD >> USE_GCC= yes >> .endif > > Yes, but shouldn't the .if simple be removed now? > > Okay, to do so, Emanuel? Yes, with 10.x being out of the picture it should be removed and USE_GCC=yes be moved up to the USE* block. Feel free to commit. Emanuel >> Modified: head/devel/libzim/Makefile > ============================================================================ >> # Using gcc6 and libstdc++ leads to error because xapian-core is linked with libc++ >> -BROKEN_FreeBSD_10= /usr/include/c++/v1/memory:4004:35: error: no viable overloaded '=' > > That comment now became obsolete, so I went ahead and remove it > (revision 483889). Hope you're fine, Steve. > > Gerald >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?73aa348d-ef4b-b4ce-5f89-fc415d9138a5>