Date: Fri, 12 Jun 2015 12:31:58 +1000 From: Kubilay Kocak <koobs@FreeBSD.org> To: Johannes Jost Meixner <xmj@FreeBSD.org> Cc: Roman Bogorodskiy <bogorodskiy@gmail.com>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, marcus@freebsd.org Subject: Re: svn commit: r389223 - in head/net-im/skype4: . files Message-ID: <557A449E.4090400@FreeBSD.org> In-Reply-To: <20150611173659.GA88250@kloomba> References: <201506111458.t5BEw4qn012538@svn.freebsd.org> <20150611173659.GA88250@kloomba>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/06/2015 3:37 AM, Roman Bogorodskiy wrote:
>> +.include <bsd.port.pre.mk>
>> > +
>> > +.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1100075
>> > +BROKEN= Skype 4.3 requires Linux 2.6.32 emulation.
> ^^^
> Nit: I guess the period is not needed here because the resulting message
> will look something like this:
>
> ===> skype4-4.3.0.37,1 is marked as broken: Skype 4.3 requires Linux
> 2.6.32 emulation..
>
portlint could have a rule added. It has one for COMMENT, but not BROKEN
et al (cc marcus)
There's also new options helpers that should be used:
* BROKEN_${OPSYS}
* BROKEN_${OPSYS}_${OSREL:R}
./koobs
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?557A449E.4090400>