From owner-freebsd-ports@FreeBSD.ORG  Tue Sep  7 19:49:20 2004
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C26E416A4CE
	for <ports@freebsd.org>; Tue,  7 Sep 2004 19:49:20 +0000 (GMT)
Received: from smtpout.mac.com (smtpout.mac.com [17.250.248.97])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AF3A343D45
	for <ports@freebsd.org>; Tue,  7 Sep 2004 19:49:20 +0000 (GMT)
	(envelope-from cswiger@mac.com)
Received: from mac.com (smtpin08-en2 [10.13.10.153])
	by smtpout.mac.com (Xserve/MantshX 2.0) with ESMTP id i87JnID2010253;
	Tue, 7 Sep 2004 12:49:20 -0700 (PDT)
Received: from [10.1.1.245] (nfw2.codefab.com [199.103.21.225] (may be
	forged))	(authenticated bits=0)i87JnEj5009792;
	Tue, 7 Sep 2004 12:49:16 -0700 (PDT)
In-Reply-To: <XFMail.20040907114725.jdp@polstra.com>
References: <XFMail.20040907114725.jdp@polstra.com>
Mime-Version: 1.0 (Apple Message framework v619)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <FEDC1A62-0106-11D9-A3E8-003065ABFD92@mac.com>
Content-Transfer-Encoding: 7bit
From: Charles Swiger <cswiger@mac.com>
Date: Tue, 7 Sep 2004 15:49:14 -0400
To: John Polstra <jdp@polstra.com>
X-Mailer: Apple Mail (2.619)
cc: FreeBSD Ports <ports@freebsd.org>
Subject: Re: Best way to override user's CFLAGS in a port?
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Sep 2004 19:49:20 -0000

On Sep 7, 2004, at 2:47 PM, John Polstra wrote:
[ ...Oliver's comments about handling CFLAGS... ]
> I'm afraid if I do that, I'll get even more bug reports.  More and
> more -current users are adding -O2 to their CFLAGS in /etc/make.conf.
> Surely all of them would prefer having the port build properly than
> having it fail intentionally.

Users would prefer the software to build properly, so yes, doing 
something to switch -Ox to plain -O is better than marking the port 
BROKEN.

I don't think that changing a specific flag in a port which needs to do 
so is unreasonable, but I dislike the notion of second-guessing the 
end-user.  The whole point of preserving CFLAGS set in /etc/make.conf 
or via the environment is to make it easy for people to build all of 
the software using whatever flags they want.

Can we help you fix the issues with ezm3 when compiled with -O2, rather 
than figuring ways to hack CFLAGS...?

-- 
-Chuck