From owner-freebsd-current@FreeBSD.ORG Tue Apr 4 04:30:46 2006 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C7F2E16A422 for ; Tue, 4 Apr 2006 04:30:46 +0000 (UTC) (envelope-from pho@holm.cc) Received: from relay03.pair.com (relay03.pair.com [209.68.5.17]) by mx1.FreeBSD.org (Postfix) with SMTP id E823543D4C for ; Tue, 4 Apr 2006 04:30:45 +0000 (GMT) (envelope-from pho@holm.cc) Received: (qmail 73093 invoked from network); 4 Apr 2006 04:30:44 -0000 Received: from unknown (HELO peter.osted.lan) (unknown) by unknown with SMTP; 4 Apr 2006 04:30:44 -0000 X-pair-Authenticated: 83.95.197.184 Received: from peter.osted.lan (localhost.osted.lan [127.0.0.1]) by peter.osted.lan (8.13.4/8.13.4) with ESMTP id k344UhDj009584; Tue, 4 Apr 2006 06:30:43 +0200 (CEST) (envelope-from pho@peter.osted.lan) Received: (from pho@localhost) by peter.osted.lan (8.13.4/8.13.4/Submit) id k344UhfI009583; Tue, 4 Apr 2006 06:30:43 +0200 (CEST) (envelope-from pho) Date: Tue, 4 Apr 2006 06:30:43 +0200 From: Peter Holm To: Kris Kennaway Message-ID: <20060404043043.GA9507@peter.osted.lan> References: <20060402094431.GA81954@peter.osted.lan> <20060402.180153.74658240.Tor.Egge@cvsup.no.freebsd.org> <20060402190910.GA12759@peter.osted.lan> <20060402.204851.78799557.Tor.Egge@cvsup.no.freebsd.org> <20060403192808.GA91475@peter.osted.lan> <20060403203402.GA89233@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060403203402.GA89233@xor.obsecurity.org> User-Agent: Mutt/1.4.2.1i Cc: truckman@freebsd.org, current@freebsd.org Subject: Re: Livelock / softdep_flush "loop" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2006 04:30:46 -0000 On Mon, Apr 03, 2006 at 04:34:03PM -0400, Kris Kennaway wrote: > On Mon, Apr 03, 2006 at 09:28:08PM +0200, Peter Holm wrote: > > On Sun, Apr 02, 2006 at 08:48:51PM +0000, Tor Egge wrote: > > > > > The enclosed patch might help. > > > > > > > > > > > > > I'm testing it right now. > > > > > > Similarly to the softdepflush process looping in softdep_flush(), the process > > > creating a snapshot might loop in ffs_sync(). > > > > > > > I ran the same test with your first patch for two hours and your > > second patch for 7 hours, without seeing any livelocks. > > > > I added snapshots to the test and still did not get any livelocks, but > > I'm not certain that this last test covers your change. > > Hmm, there is a PR reporting hangs when removing many files with > snapshots enabled, on 6.0. I tried to reproduce it on 6.1 but failed > with the test case that the PR said was a reliable cause for them, so > I assumed it was fixed. It may be that I didn't try hard enough > though, since I didn't see your problem either. > I'll pursue this problem as I've seen this once recently. - Peter > Kris > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.2.2 (FreeBSD) > > iD8DBQFEMYa6Wry0BWjoQKURAr6DAKD5iGz6aYO5LNPlgFj4RixFonaJfQCgt3S3 > gut18DnWCkJsG6rmLzp6wx8= > =hHdh > -----END PGP SIGNATURE----- -- Peter Holm