Date: Fri, 2 Apr 2010 00:20:12 -0700 From: Garrett Cooper <yanefbsd@gmail.com> To: Xin LI <delphij@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: HEADSUP: zlib updated [svn commit: r205471 - in head: . lib/libz lib/libz/contrib lib/libz/doc sys/sys] Message-ID: <g2u7d6fde3d1004020020i1cf2a5cekd6156b84ed187155@mail.gmail.com> In-Reply-To: <h2ga78074951004012130w2efad015o91226aa98dfd230b@mail.gmail.com> References: <4BA7E0B8.3080406@delphij.net> <4BAE2B4F.6060005@protected-networks.net> <4BB3FD5D.9070600@uffner.com> <r2oa78074951003312051kca872e0el511273674bd9e4b@mail.gmail.com> <4BB4FB35.2040703@uffner.com> <h2ga78074951004012130w2efad015o91226aa98dfd230b@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 1, 2010 at 9:30 PM, Xin LI <delphij@gmail.com> wrote:
> Hi, Tom,
>
> On Thu, Apr 1, 2010 at 12:59 PM, Tom Uffner <tom@uffner.com> wrote:
> [...]
>> i realize this. i was just adding to the list of ports that no longer
>> build after this change. ghostscript is kind of important for print
>> support.
>>
>> i doubt this is "right" either, but it is a quick & dirty way to
>> make mplayer compile again:
>>
>> --- configure.orig =A0 =A0 =A02010-04-01 15:49:37.000000000 -0400
>> +++ configure =A0 2010-04-01 15:50:50.000000000 -0400
>> @@ -5337,7 +5337,7 @@
>> =A0#include <dvdread/nav_read.h>
>> =A0int main(void) { return 0; }
>> =A0EOF
>> - =A0 =A0cc_check -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64
>> -D_LARGEFILE64_SOURCE \
>> + =A0 =A0cc_check -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64 \
>> =A0 =A0 =A0 -ldvdread $_ld_dl && _dvdread=3Dyes && _res_comment=3D"exter=
nal"
>> =A0 fi
>> =A0fi
>> @@ -7412,8 +7412,6 @@
>> =A0if test "$_largefiles" =3D yes || freebsd ; then
>> =A0 CFLAGS=3D"$CFLAGS -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64"
>> =A0 if test "$_dvdread" =3D yes || test "$_libdvdcss_internal" =3D yes ;=
then
>> - =A0 =A0# dvdread support requires this (for off64_t)
>> - =A0 =A0CFLAGS=3D"$CFLAGS -D_LARGEFILE64_SOURCE"
>> =A0 =A0 cygwin && CFLAGS=3D"$CFLAGS -DSYS_CYGWIN"
>> =A0 fi
>> =A0fi
>
> Specifying -DFOO basically means in C code one have:
>
> %%%
> #define FOO 1
> %%%
Actually, `CFLAGS +=3D -DFOO=3D1' is different from `CFLAGS +=3D -DFOO' (I
think Xin Li meant to state the former format).
$ for i in -DBAR -DFOO -DFOO=3D1 -DFOO=3D2; do echo "$i"; cc -c $i
test_defined.c; done
-DBAR
-DFOO
test_defined.c:2:2: warning: #warning FOO is defined
test_defined.c:6:2: warning: #warning FOO is 1
test_defined.c:10:2: warning: #warning FOO is non-zero
-DFOO=3D1
test_defined.c:2:2: warning: #warning FOO is defined
test_defined.c:6:2: warning: #warning FOO is 1
test_defined.c:10:2: warning: #warning FOO is non-zero
-DFOO=3D2
test_defined.c:2:2: warning: #warning FOO is defined
test_defined.c:10:2: warning: #warning FOO is non-zero
$ cat test_defined.c
#ifdef FOO
#warning FOO is defined
#endif
#if FOO =3D=3D 1
#warning FOO is 1
#endif
#if FOO
#warning FOO is non-zero
#endif
[...]
Thanks,
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?g2u7d6fde3d1004020020i1cf2a5cekd6156b84ed187155>