Date: Fri, 08 Mar 2019 19:50:39 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: Brooks Davis <brooks@freebsd.org> Cc: Adam Weinberger <adamw@adamw.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r495007 - in head/devel: . llvm Message-ID: <4l8d-9p4w-wny@FreeBSD.org> In-Reply-To: <20190308180601.GH78397@spindle.one-eyed-alien.net> (Brooks Davis's message of "Fri, 8 Mar 2019 18:06:01 %2B0000") References: <201903080040.x280ewF0084625@repo.freebsd.org> <CAP7rwciJ=pgiigGgDjutfRSLYV8qQYNaWuFckVDDyGypZMLjLw@mail.gmail.com> <20190308180601.GH78397@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Brooks Davis <brooks@freebsd.org> writes:
> On Fri, Mar 08, 2019 at 06:03:55AM -0700, Adam Weinberger wrote:
>
>> On Thu, Mar 7, 2019 at 5:41 PM Brooks Davis <brooks@freebsd.org> wrote:
>> >
>> > It is intended for use by users and should not be a port build dependency.
>>
>> Perhaps a comment near the top of the Makefile about this could be
>> helpful. Right now there's nothing in the Makefile or pkg-descr to
>> inform future porters of this important implementation detail.
>
> What I'd really like is a way to declare a port as ineligible to be a
> dependency.
Like the following?
$ DEVELOPER=1 make check-sanity
/!\ foo-0.1: Makefile errors /!\
devel/llvm in BUILD_DEPENDS is unsupported, please use devel/llvm60 instead
*** Error code 1
Stop.
make: stopped in /usr/ports/misc/foo
--- Mk/bsd.sanity.mk.orig
+++ Mk/bsd.sanity.mk
@@ -70,6 +70,14 @@ DEV_WARNING+= "Not validating first entry in CATEGORIES due to being outside of
DEV_ERROR+= "USE_PERL5=yes is unsupported, please use USES=perl5 instead"
.endif
+.if !empty(BUILD_DEPENDS:M*devel/llvm)
+DEV_ERROR+= "devel/llvm in BUILD_DEPENDS is unsupported, please use devel/llvm${LLVM_DEFAULT} instead"
+.endif
+
+.if !empty(BUILD_DEPENDS:M*lang/gcc)
+DEV_ERROR+= "lang/gcc in BUILD_DEPENDS is unsupported, please use USE_GCC=yes instead"
+.endif
+
.if !empty(LIB_DEPENDS:M*/../*)
DEV_ERROR+= "LIB_DEPENDS contains unsupported relative path to dependency"
.endif
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4l8d-9p4w-wny>