From owner-freebsd-net@FreeBSD.ORG Sat Aug 23 21:42:17 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 62E00106564A for ; Sat, 23 Aug 2008 21:42:17 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.9.129]) by mx1.freebsd.org (Postfix) with ESMTP id 19D0D8FC16 for ; Sat, 23 Aug 2008 21:42:16 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id 74EB573098; Sat, 23 Aug 2008 23:44:52 +0200 (CEST) Date: Sat, 23 Aug 2008 23:44:52 +0200 From: Luigi Rizzo To: Roman Kurakin Message-ID: <20080823214452.GA75815@onelab2.iet.unipi.it> References: <48B07DC5.2030203@localhost.inse.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48B07DC5.2030203@localhost.inse.ru> User-Agent: Mutt/1.4.2.3i Cc: freebsd-net@freebsd.org Subject: Re: [Fwd: IPFW PATCH: make the IPFW_DEFUALT_RULE number constant non private] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Aug 2008 21:42:17 -0000 On Sun, Aug 24, 2008 at 01:14:45AM +0400, Roman Kurakin wrote: > Hi, > > The IPFW_DEFAULT_RULE is also the max allowed rule number. > This value should be definitely public, so here is the patch, if there is > no objections I'll commit it within a couple of days. > After that, I plan to fix a couple of tools that need to know this value. unless the tools you have in mind already include ip_fw.h (in which case the change is harmless and I have no objection), i think it would be better to export the value in a sysctl and let the tools fetch it from there, so they do not need to include the header. cheers luigi