Date: Sat, 19 Oct 2013 16:57:02 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r330906 - head/multimedia/vcdpad Message-ID: <20131019165702.GA64069@FreeBSD.org> In-Reply-To: <20131019163946.GF57066@ithaqua.etoilebsd.net> References: <201310191630.r9JGUXZJ049165@svn.freebsd.org> <20131019163648.GA61417@FreeBSD.org> <20131019163946.GF57066@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 19, 2013 at 06:39:46PM +0200, Baptiste Daroussin wrote: > On Sat, Oct 19, 2013 at 04:36:48PM +0000, Alexey Dokuchaev wrote: > > On Sat, Oct 19, 2013 at 04:30:33PM +0000, Baptiste Daroussin wrote: > > > New Revision: 330906 > > > URL: http://svnweb.freebsd.org/changeset/ports/330906 > > > > > > [...] > > > +post-install: > > > + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/${PORTNAME} > > > > How do you know if installed binaries should be post-stripped? Is there > > automated check involved? What if, for any reason, binary indeed must be > > installed unstripped? > > make stage warns about unstripped binaries if you have DEVELOPERS=YES in your > make.conf, I suppose it should read DEVELOPER, not DEVELOPER_S_, right? > if you need the binaries unstripped then just do not strip them, those works > stripped properly, btw STRIP_CMD respects WITH_DEBUG. <pessimistic mode on> I understand; I was worrying about rare cases when stripping the binary (not for debugging) actually renders it unusable in certain circumstances. Don't get me wrong, I also prefer to have installed binaries normally stripped, but I vaguely recall there were cases, albeit rarely seen, when upstream actually intended unstripped installs, for a reason. I just hope that these sorts of automatic suggestions would not result in massive commits that would result in broken installations. From what I see how easily folks follow portlint's sometimes misguided advice, it could become problem. </pessimistic mode off> ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131019165702.GA64069>