From owner-freebsd-hackers@FreeBSD.ORG Wed May 7 15:32:15 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 09DA01A9 for ; Wed, 7 May 2014 15:32:15 +0000 (UTC) Received: from mailgate.gta.com (mailgate.gta.com [199.120.225.23]) by mx1.freebsd.org (Postfix) with ESMTP id 760CA81A for ; Wed, 7 May 2014 15:32:13 +0000 (UTC) Received: (qmail 28293 invoked by uid 1000); 7 May 2014 15:32:13 -0000 Date: Wed, 7 May 2014 11:32:13 -0400 From: Larry Baird To: Ermal Lu??i Subject: Re: apu1c led driver Message-ID: <20140507153212.GA27305@gta.com> References: <20140422020109.GA57760@gta.com> <69BC3E8E-A5D1-4CAD-96A0-9139FFBD8AA3@netgate.com> <20140507144631.GA24565@gta.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Cc: Freebsd hackers list , Jim Thompson X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 May 2014 15:32:15 -0000 Ermal, > Have to fix that part. I fixed this and used fixed version to reset leds on driver unload. > Also you have a leak of led devs in your loop while attaching if something > goes wrong. > Need to fix that or i can fix that when i come to it! Opps, left over return. Fixed in attached version. Larry -- ------------------------------------------------------------------------ Larry Baird Global Technology Associates, Inc. 1992-2012 | http://www.gta.com Celebrating Twenty Years of Software Innovation | Orlando, FL Email: lab@gta.com | TEL 407-380-0220