Date: Tue, 21 Sep 2004 13:01:32 GMT From: Pavel Gubin <pg@ie.tusur.ru> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/71972: "make buildkernel" fails when "options RESTARTABLE_PANICS" is set Message-ID: <200409211301.i8LD1WpP013640@www.freebsd.org> Resent-Message-ID: <200409211310.i8LDADb0063258@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 71972 >Category: misc >Synopsis: "make buildkernel" fails when "options RESTARTABLE_PANICS" is set >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Sep 21 13:10:13 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Pavel Gubin >Release: RELENG_5 >Organization: TUCS&R >Environment: FreeBSD lynx.ie.tusur.ru 5.3-BETA5 FreeBSD 5.3-BETA5 #9: Mon Sep 20 03:04:23 TSD 2004 pg@lynx.ie.tusur.ru:/var/data/5/obj/var/data/5/src/sys/Lynx i386 >Description: When "options RESTARTABLE_PANICS" is enabled, gcc finds a warnings in many source modules, like this: .. /src/sys/fs/devfs/devfs_devs.c: In function `devfs_itor': /src/sys/fs/devfs/devfs_devs.c:82: warning: control reaches end of non-void function .. and then build fails because of -Werror. The warnings like this one also found in: /sys/kern/kern_intr.c /sys/kern/subr_bus.c /sys/kern/subr_witness.c and possibly other places. The warnings are appeared because RESTARTABLE_PANICS changes panic() prototype definition in sys/systm.h:324: #ifdef RESTARTABLE_PANICS void panic(const char *, ...) __printflike(1, 2); #else void panic(const char *, ...) __dead2 __printflike(1, 2); #endif >How-To-Repeat: Add an "options RESTARTABLE_PANICS" line into kernel configfile, then "make buildkernel" breaks. >Fix: I've tried to quickly fix a problem by inserting `for(;;);' aftel call to panic() in the files which are failed to compile, but after a 4 or 5 fixes decided that there must be 'a more right way' to fix this. >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409211301.i8LD1WpP013640>