From owner-freebsd-xfce@freebsd.org Thu Oct 12 05:04:55 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 41A13E439E4 for ; Thu, 12 Oct 2017 05:04:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 2AA0765D2F for ; Thu, 12 Oct 2017 05:04:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 29C51E439E2; Thu, 12 Oct 2017 05:04:55 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 295B3E439E1 for ; Thu, 12 Oct 2017 05:04:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1873D65D2E for ; Thu, 12 Oct 2017 05:04:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v9C54sCE036464 for ; Thu, 12 Oct 2017 05:04:54 GMT (envelope-from bugzilla-noreply@freebsd.org) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: maintainer-feedback requested: [Bug 222942] misc/xfce4-weather-plugin: Update to 0.8.10 Date: Thu, 12 Oct 2017 05:04:55 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch-ready X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2017 05:04:55 -0000 Olivier Duchateau has reassigned Bugzilla Automation 's request for maintainer-feedback to xfce@FreeBSD.org: Bug 222942: misc/xfce4-weather-plugin: Update to 0.8.10 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222942 --- Description --- Created attachment 187091 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D187091&action= =3Dedit Patch to update misc/xfce4-weather-plugin - Update to 0.8.10 - Remove unneeded patch Note: tested with xfce4-panel 4.13.1 (Gtk3 only) I noticed some icons disappeared (since switch to Gtk3, icons in panel are loaded differently), = so in panel 4.12.x everythin should be fine. Moreover in my 4.13 branch [1], I have patch, which fixes logical GtkOrientation enum (previous releases are also affected): weather.c:2035:31: warning: implicit conversion from enumeration type 'XfcePanelPluginMode' to different enumeration type 'GtkOrientation' [-Wenum-conversion] data->panel_orientation =3D xfce_panel_plugin_get_mode(panel); ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ weather.c:2038:34: warning: comparison of constant 'XFCE_PANEL_PLUGIN_MODE_DESKBAR' (2) with expression of type 'GtkOrientatio= n' is always false [-Wtautological-constant-out-of-range-compare] (data->panel_orientation =3D=3D XFCE_PANEL_PLUGIN_MODE_DESKBAR && ~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ As my patch is not yet review by upstream, and follow the FreeBSD Xfce team= 's policy i'm waiting in order to propose my patch in the official ports tree. [1] https://app.assembla.com/spaces/xfce4/subversion/source/HEAD/tags/4.13/misc= /xfc e4-weather-plugin/files/patch-panel-plugin_weather.c