Date: Sat, 12 Jun 2010 08:03:47 -0400 From: jhell <jhell@dataix.net> To: Ivan Voras <ivoras@freebsd.org> Cc: freebsd-fs@freebsd.org, Alexander Leidinger <Alexander@leidinger.net> Subject: Re: CFT: periodic scrubbing of ZFS pools Message-ID: <4C1377A3.2040408@dataix.net> In-Reply-To: <AANLkTilBqAsDnDs4nlsVjBdt1U9554t9rNuzMruqRJqE@mail.gmail.com> References: <20100610162629.38992mazf0sfdqg0@webmail.leidinger.net> <hut8o7$q2o$1@dough.gmane.org> <20100611172033.42001s90ahe57oe8@webmail.leidinger.net> <AANLkTilBqAsDnDs4nlsVjBdt1U9554t9rNuzMruqRJqE@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/11/2010 12:11, Ivan Voras wrote: > On 11 June 2010 17:20, Alexander Leidinger <Alexander@leidinger.net> wrote: >> Quoting Ivan Voras <ivoras@freebsd.org> (from Fri, 11 Jun 2010 14:04:24 >> +0200): > >>> Fairly good and useful, but could you add a small check of "zpool >>> status" information before scrubbing that would a) complain LOUDLY AND >>> VISIBLY if a previous scrub failed and b) skip issuing a new scrub >>> command if there is such an error, to avoid stressing possibly broken >>> hardware? >> >> Can you please provide an example of such a failed scrub? > > You should probably treat any status message that doesn't have "none > requested" or "scrub completed with 0 errors..." as failed. I disagree with this as it conflicts with your previous request. none requested = no error and the next scrub should be allowed scrub completed with 0 errors = no errors. Why shouldn't the next scrub that is being determined in the script take place if there is no errors ?. I only see doing this if you want the scrub to only ever be performed once and never again thereafter. I do agree on the other hand if the scrub status has any form of [fF][aA][iI][dD] in it then it should not be performed and as well if it contains [fF][aA][uU][lL][tT][eE][dD] or some other combinations on one of the devices. Regards, -- jhell
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C1377A3.2040408>