From owner-freebsd-current@freebsd.org Sat Jun 27 01:56:58 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B51CD365A62; Sat, 27 Jun 2020 01:56:58 +0000 (UTC) (envelope-from neel@neelc.org) Received: from rainpuddle.neelc.org (rainpuddle.neelc.org [IPv6:2001:19f0:8001:fed:5400:2ff:fe73:c622]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49txh93JQfz487G; Sat, 27 Jun 2020 01:56:54 +0000 (UTC) (envelope-from neel@neelc.org) Received: from mail.neelc.org (rainpuddle.neelc.org [IPv6:2001:19f0:8001:fed:5400:2ff:fe73:c622]) by rainpuddle.neelc.org (Postfix) with ESMTPSA id 668EEEB298; Fri, 26 Jun 2020 18:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neelc.org; s=mail; t=1593223006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=q4UMQZN+nIWQKdNZg2nsmUBvZGoEw0OXF9Tp/MCkcZw=; b=eLYiQjPyV3A5tId7YZyR4JJZFTmE4Q1Eu38FX4s5wifAEx5NprbR/gDrxQnx44UGroxlRM L4vZRxfTiWWkEdTkXBsdUduE3dEksYR+RW6xZaDPVeiGNhhDVf7DxP1ZBodSBAUiu702d8 fkWURzTwjdvcdomx6nnw4JIuuvvmXIFSTe51DJS7J+LZ3cf/T2/Q/08jgDffg1PMw8lxoV kpFUP9RdIOfPTpbw+F5yzdSQPksNJADPo/7WlcopbICD7sJVrlOMO09as18C4u3vGp2YdO grYVKflsvZdFmfTABsR63QTAWiv7PXc62NUWb5PMSmzAuwww/S9oQYzM0GBPew== MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 26 Jun 2020 18:56:44 -0700 From: Neel Chauhan To: freebsd-current@freebsd.org, freebsd-hackers@freebsd.org Cc: mmacy@freebsd.org, bsdimp@freebsd.org Subject: r362666 breaking buildworld (don't know how to make nvpair.c) & Fix/Patch User-Agent: Roundcube Webmail/1.4.2 Message-ID: X-Sender: neel@neelc.org X-Rspamd-Queue-Id: 49txh93JQfz487G X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=neelc.org header.s=mail header.b=eLYiQjPy; dmarc=pass (policy=none) header.from=neelc.org; spf=pass (mx1.freebsd.org: domain of neel@neelc.org designates 2001:19f0:8001:fed:5400:2ff:fe73:c622 as permitted sender) smtp.mailfrom=neel@neelc.org X-Spamd-Result: default: False [-3.16 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[neelc.org:s=mail]; NEURAL_HAM_MEDIUM(-1.00)[-0.997]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; NEURAL_HAM_LONG(-0.98)[-0.981]; DKIM_TRACE(0.00)[neelc.org:+]; DMARC_POLICY_ALLOW(-0.50)[neelc.org,none]; NEURAL_HAM_SHORT(-0.29)[-0.287]; RCVD_COUNT_ONE(0.00)[1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:20473, ipnet:2001:19f0:8000::/38, country:US]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ONCE_RECEIVED(0.10)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jun 2020 01:56:58 -0000 Hi, When I attempt to build world in 13-CURRENT, I get this error: ===> lib/libnv (obj,includes,all,install) [Creating objdir /usr/obj/usr/src/amd64.amd64/tmp/obj-tools/lib/libnv...] make[3]: make[3]: don't know how to make nvpair.c. Stop make[3]: stopped in /usr/src/lib/libnv *** [legacy] Error code 2 make[2]: stopped in /usr/src 1 error make[2]: stopped in /usr/src *** [_legacy] Error code 2 make[1]: stopped in /usr/src 1 error make[1]: stopped in /usr/src *** [buildworld] Error code 2 make: stopped in /usr/src 1 error make: stopped in /usr/src root@omen:/usr/src # The build broke with mmacy@'s commit r362666 which renamed nvpair.c to bsd_nvpair.c without renaming the Makefile. Is anyone else having this error? I have a patch to unbreak the build here: https://reviews.freebsd.org/D25481 Does the patch work? Best, Neel Chauhan