Date: Thu, 15 Nov 2012 18:01:16 +0000 From: Attilio Rao <attilio@freebsd.org> To: Adrian Chadd <adrian@freebsd.org> Cc: Ian Lepore <freebsd@damnhippie.dyndns.org>, freebsd-arch@freebsd.org, freebsd-hackers@freebsd.org Subject: Re: [RFQ] make witness panic an option Message-ID: <CAJ-FndC=JtgsLNWEcws32RmBgtegxPV%2BTXBi%2BPwYQhsRYxNDFg@mail.gmail.com> In-Reply-To: <CAJ-VmokcgHMYZC2v_fGvBBk1MfzkkfOecaJ%2B3MQrBN4nRG5GCA@mail.gmail.com> References: <CAJ-Vmo=i=Amo_QqHi4GnGie0Gc0YnK3XaRKjvBO-=SFboFYPmA@mail.gmail.com> <1353001175.1217.153.camel@revolution.hippie.lan> <CAJ-FndBP5Pi=SCpyBLK3b=HM_gQ9u8M4%2B1tLk9tA5X-gqismVA@mail.gmail.com> <47374EC3-5022-49AC-A17E-7F234A88B5C6@bsdimp.com> <CAJ-VmokcgHMYZC2v_fGvBBk1MfzkkfOecaJ%2B3MQrBN4nRG5GCA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/15/12, Adrian Chadd <adrian@freebsd.org> wrote: > On 15 November 2012 09:56, Warner Losh <imp@bsdimp.com> wrote: > >>> Do you really think that an abusable mechanism will help here rather > >> It sounds like he's more worried about introducing LoRs into his wireless >> code. They are harmless, for him, and he can fix them by reloading the >> driver. They are only harmful if he loses a race. > > LOR's and lock assertions. Ie, I want to find out at run time that a > lock wasnt' held at a certain position but continue soldiering on. > That's how I've been finding out all of the races in net80211/ath, as > there wasn't locking where there needed to be. I think that your worries are focused more around the latter than the former, which can be easilly shut down already today. And frankly I will never be in favor of a patch that automatically shutdowns lock assertion. Please patch your local code to do so but don't add any generic/upstream/all-around mechanism for that. Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndC=JtgsLNWEcws32RmBgtegxPV%2BTXBi%2BPwYQhsRYxNDFg>