From owner-svn-src-all@FreeBSD.ORG Sun Dec 16 09:10:29 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 01768248; Sun, 16 Dec 2012 09:10:29 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id F08DE8FC19; Sun, 16 Dec 2012 09:10:27 +0000 (UTC) Received: by mail-ee0-f54.google.com with SMTP id c13so2662112eek.13 for ; Sun, 16 Dec 2012 01:10:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=0WODQ7D8Gh8WBDgeGVuatWZrkTtTF2exc2u+/wxuMnA=; b=kufFUK7PC2cZwLWOvtnooSQJi6uVrHUQV0pHt+riTmMZNRvZX1k8+4MJ1vaO4lsYlI XEcckrBFO/g5jz2UfXTHvYSop5vKxOShlNoX8iBTiIALq2fZSsQgHIPogSTIXclws6hv xJWEd4U+X2P72hWioNJKNMs2p351rBAcj2t5/At/5miecEuSYJckccWNYU6HQL/xyyk7 hV0dmKWSL67P0SApdbhRJH2hEyhQe7Yu9vhNgRfyc6nLWds66sXxhHoqYB2wHLUgVLnk bxLFXB7l5DDHx8Adra0aI/NgjPEIC86AaU6t4PJv4hhxDh+1jztNMlj7gavnGTRyRRHI pUzg== Received: by 10.14.176.66 with SMTP id a42mr30821034eem.34.1355649021356; Sun, 16 Dec 2012 01:10:21 -0800 (PST) Received: from localhost ([178.150.115.244]) by mx.google.com with ESMTPS id 6sm21214030eea.3.2012.12.16.01.10.19 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 16 Dec 2012 01:10:20 -0800 (PST) Sender: Mikolaj Golub Date: Sun, 16 Dec 2012 11:10:17 +0200 From: Mikolaj Golub To: Adrian Chadd Subject: Re: svn commit: r244271 - head/usr.sbin/iostat Message-ID: <20121216091016.GA3331@gmail.com> References: <201212151821.qBFILAOP013123@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Dec 2012 09:10:29 -0000 On Sat, Dec 15, 2012 at 05:00:39PM -0800, Adrian Chadd wrote: > Hi, > > People may have scripts based on the current output. > > You should have introduced a new parameter which modifies the output > behaviour in the way you wanted, rather than modifying the existing > behaviour. > > Please consider reverting your change (which is a good idea, btw) and > adding a new modifier that outputs the value(s), rather than a %age. It is a pity that this question did not arise when I published this patch on hackers@: http://lists.freebsd.org/pipermail/freebsd-hackers/2012-September/040558.html I got then only one (private) reply from David Wolfskill, who though it was a good idea but had to go only to head (10.x) due to the changed behavior. I don't have plans to MFC this. I will revert the change, if other people also think I have to. I wont add a new modifier introducing yet another ugliness to iostat(8): iostat -Ix behavior before the change contradicted what was described in the man: -I Display total statistics for a given time period, rather than aver- age statistics for each second during that time period. In my opinion, preserving the wrong behaviour and adding yet another switch to have the desirable one is worse. So I'd rather just revert this back and keep using my sysutils/devstat utility, which already gives me what I want. -- Mikolaj Golub