Date: Mon, 23 Aug 2010 10:23:59 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Dimitry Andric <dimitry@andric.com> Cc: Bruce Cran <bruce@cran.org.uk>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bruce Evans <bde@freebsd.org> Subject: Re: svn commit: r211304 - head/lib/libutil Message-ID: <86y6bxybxc.fsf@ds4.des.no> In-Reply-To: <4C7194E6.6080708@andric.com> (Dimitry Andric's message of "Sun, 22 Aug 2010 23:21:42 %2B0200") References: <201008141434.o7EEYaSA030301@svn.freebsd.org> <20100815205724.00007e0f@unknown> <86wrrraqk8.fsf@ds4.des.no> <4C7194E6.6080708@andric.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Dimitry Andric <dimitry@andric.com> writes: > Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: > > Bruce Cran <bruce@cran.org.uk> writes: > > > Somewhat related, there are overflow bugs in humanize_number - for > > > example df(1) fails to display space from a 100PB filesystem > > > correctly. > > Patch? :) > Attached. This makes humanize_number() work properly for all possible > int64_t values. That's awesome! Any way I can convince you to fix expand_number() as well? I got a detailed explanation of what's wrong with it (both before and after my commits) from bde@ (cc:ed) in private correspondence; I can forward it to you if he doesn't mind. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86y6bxybxc.fsf>