From owner-freebsd-isdn Tue Sep 28 22: 1:42 1999 Delivered-To: freebsd-isdn@freebsd.org Received: from linteuto.teuto.de (temp-mail.teuto.de [194.77.23.26]) by hub.freebsd.org (Postfix) with ESMTP id 7A80414E54 for ; Tue, 28 Sep 1999 22:01:38 -0700 (PDT) (envelope-from martin@rumolt.teuto.de) Received: from rumolt.teuto.de (rumolt.teuto.de [212.8.203.81]) by linteuto.teuto.de (8.9.3/8.9.3) with ESMTP id HAA30359; Wed, 29 Sep 1999 07:01:33 +0200 Received: from martins (hwart.teuto.de [212.8.203.83]) by rumolt.teuto.de (8.8.8/8.8.8) with SMTP id HAA00325; Wed, 29 Sep 1999 07:01:22 +0200 (MEST) From: "Martin Husemann" To: "Gary Jennejohn" , Cc: Subject: RE: problems with 0.83 and sPPP Date: Wed, 29 Sep 1999 07:01:23 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2910.0) In-Reply-To: <199909282132.XAA00525@peedub.muc.de> Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V4.72.3110.3 Sender: owner-freebsd-isdn@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > + u_long subcmd; > struct ifreq *ifr = (struct ifreq *)data; > struct spppreq spr; > > /* > * ifr->ifr_data is supposed to point to a struct spppreq. > + * Check the cmd word first before attempting to fetch all the > + * data. > + */ > + if ((subcmd = fuword(ifr->ifr_data)) == -1) > + return EFAULT; > + > + /* > + * ifr->ifr_data is supposed to point to a struct spppreq. This is bogus. It relies on knowledge of the compilers structure packing and it doesn't work on alpha. We explicitly removed it some versions ago... The much simpler solution is to cast spr.cmd to the right type in the switch() or fix it's declaration ;-) Martin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message