From owner-svn-src-all@freebsd.org Mon Oct 9 20:43:58 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4E6CBE3B8BA; Mon, 9 Oct 2017 20:43:58 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 28B3B7F17C; Mon, 9 Oct 2017 20:43:58 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 106D75A9F27; Mon, 9 Oct 2017 20:33:51 +0000 (UTC) Date: Mon, 9 Oct 2017 20:33:50 +0000 From: Brooks Davis To: rgrimes@freebsd.org Cc: Ngie Cooper , Sean Bruno , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r324406 - head/sys/modules/em Message-ID: <20171009203350.GB68389@spindle.one-eyed-alien.net> References: <95D45458-24C3-473C-80AF-A2C622747886@gmail.com> <201710081542.v98FgZ5f074039@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="b5gNqxB1S1yM7hjW" Content-Disposition: inline In-Reply-To: <201710081542.v98FgZ5f074039@pdx.rh.CN85.dnsmgr.net> User-Agent: Mutt/1.8.3 (2017-05-23) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 20:43:58 -0000 --b5gNqxB1S1yM7hjW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 08, 2017 at 08:42:35AM -0700, Rodney W. Grimes wrote: > >=20 > > > On Oct 7, 2017, at 16:33, Sean Bruno wrote: > > >=20 > > > Author: sbruno > > > Date: Sat Oct 7 23:33:14 2017 > > > New Revision: 324406 > > > URL: https://svnweb.freebsd.org/changeset/base/324406 > > >=20 > > > Log: > > > Fix symlink if_igb.ko in -current such that its relative and doesn't > > > end up with non-standard DESTDIR information in its symlink. This > > > can happen very trivially if the release scripts are used. > > >=20 > > > Sponsored by: Limelight Networks > > >=20 > > > Modified: > > > head/sys/modules/em/Makefile > > >=20 > > > Modified: head/sys/modules/em/Makefile > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- head/sys/modules/em/Makefile Sat Oct 7 23:30:57 2017 (r324= 405) > > > +++ head/sys/modules/em/Makefile Sat Oct 7 23:33:14 2017 (r324= 406) > > > @@ -23,6 +23,6 @@ CFLAGS +=3D -I${SRCTOP}/sys/dev/e1000 > > > #CFLAGS +=3D -DDEVICE_POLLING > > >=20 > > > afterinstall: > > > - ln -sf ${DESTDIR}${KMODDIR}/${KMOD}.ko ${DESTDIR}${KMODDIR}/if_i= gb.ko > > > + cd ${DESTDIR}${KMODDIR} && ln -sf if_em.ko if_igb.ko > >=20 > > While this is definitely better, the same thing could be achieved via: > >=20 > > ln -sf if_em.ko ${DESTDIR}/.../if_igb.ko >=20 > Should this be using SYMLINK+=3D as I thought using ln -sf was a breakage > for meta mode stuff? At the very least it should use INSTALL_LIBSYMLINK or INSTALL_RLIBSYMLINK. Direct use of ln(1) is always a bug in install targets and ideally we would make it fail. (It breaks NO_ROOT installs by failing to add an entry to the METALOG file). -- Brooks --b5gNqxB1S1yM7hjW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJZ290uAAoJEKzQXbSebgfAJUcH/iJUHmSlEGqliH+uqHZ51w3p M/+iBM3rGUHAbEE9dL0+qvY/FaZ+DQZh7sxoyOlfppWpdhIEFalDX/pXVy/1pgwW pdOYvVA5ZJgFdJLkKO9LT7yhwessZu9CbxKV+5ZZpZqW9rWzov7gg8q4RANtzR0q PJgTZetq81elAxY3o7tn1KTd2d0Ef29EvWnU4IsRwim3Zj/lCAFHHH3171BzmZKw eX3Orp8p1fgrcQZT+E2KFmSDp/svOQPnU0vz5DwpfWbkLXLeZBTJxYO3ao72GbqP w9CaJULZlhfzXuQcN4p0NAFMYJCzmPHjR6GvIy+1ubpFoLny1jgGmd0gILqBqLM= =smL7 -----END PGP SIGNATURE----- --b5gNqxB1S1yM7hjW--