Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Feb 2006 10:46:28 -0500
From:      Ed Maste <emaste@phaedrus.sandvine.ca>
To:        Ruslan Ermilov <ru@FreeBSD.ORG>
Cc:        cvs-src@FreeBSD.ORG, Gleb Smirnoff <glebius@FreeBSD.ORG>, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/dev/em if_em.c
Message-ID:  <20060215154628.GA94447@sandvine.com>
In-Reply-To: <20060215151508.GC96442@ip.net.ua>
References:  <200602151345.k1FDj2Aq013830@repoman.freebsd.org> <20060215151508.GC96442@ip.net.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 15, 2006 at 05:15:09PM +0200, Ruslan Ermilov wrote:

> On Wed, Feb 15, 2006 at 01:45:02PM +0000, Gleb Smirnoff wrote:
> > glebius     2006-02-15 13:45:02 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/dev/em           if_em.c 
> >   Log:
> >   em_hardware_init() in em_init() is not needed, and leads to annoying
> >   link flap.
> >   
> >   Submitted by:   ru, Mike Tancsa
> >   
> >   Revision  Changes    Path
> >   1.112     +0 -7      src/sys/dev/em/if_em.c
> > 
> Hmm, I have abandoned this change locally, as it was causing me
> some problems I cannot fully recall now.  Perhaps it was *NOT*
> reprogramming the receive filter on a MAC change, I don't
> remember.

I discovered that on 5.4 also (the rx filter not being written
on a MAC addr change).  When I looked into it a while back it
appeared that the behaviour would be no different on HEAD.

-ed



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060215154628.GA94447>