Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 01 Dec 2014 14:07:45 +0100
From:      =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To:        Bryan Venteicher <bryanv@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r273331 - in head: sbin/ifconfig share/man/man4 sys/conf sys/modules sys/modules/if_vxlan sys/net sys/sys
Message-ID:  <86vblvfrha.fsf@nine.des.no>
In-Reply-To: <86zjb7frz0.fsf@nine.des.no> ("Dag-Erling =?utf-8?Q?Sm=C3=B8r?= =?utf-8?Q?grav=22's?= message of "Mon, 01 Dec 2014 13:57:07 %2B0100")
References:  <201410201442.s9KEggqt096167@svn.freebsd.org> <86zjb7frz0.fsf@nine.des.no>

next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Sm=C3=B8rgrav <des@des.no> writes:
> Bryan Venteicher <bryanv@FreeBSD.org> writes:
> > Log:
> >   Add vxlan interface
> >   [...]
> This breaks the existing "group" command, which means I now have
> machines that won't boot without manual intervention because their
> firewall rulesets rely on interface groups.

I added code to cmd_register() in ifconfig.c to warn about duplicate
commands.  Here is a complete list of pre-existing commands which the
vxlan code shadows:

ifconfig: duplicate command: group
ifconfig: duplicate command: timeout
ifconfig: duplicate command: maxaddr
ifconfig: duplicate command: learn
ifconfig: duplicate command: -learn
ifconfig: duplicate command: flush
ifconfig: duplicate command: flushall

so, in addition to breaking interface groups, it breaks bridge
interfaces.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86vblvfrha.fsf>