From owner-freebsd-hackers@FreeBSD.ORG Mon Jul 16 11:31:44 2012 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 67755106567B; Mon, 16 Jul 2012 11:31:44 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id EA6F78FC0A; Mon, 16 Jul 2012 11:31:42 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id OAA02997; Mon, 16 Jul 2012 14:31:41 +0300 (EEST) (envelope-from avg@FreeBSD.org) Message-ID: <5003FB9D.90909@FreeBSD.org> Date: Mon, 16 Jul 2012 14:31:41 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120625 Thunderbird/13.0.1 MIME-Version: 1.0 To: "Andrey V. Elsukov" References: <4FE9B01C.30306@yandex.ru> <5003EBAB.6030507@FreeBSD.org> <5003F39D.6030808@FreeBSD.org> <5003F589.40603@FreeBSD.org> <5003F79E.1060706@FreeBSD.org> In-Reply-To: <5003F79E.1060706@FreeBSD.org> X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 8bit Cc: freebsd-hackers , Marius Strobl , freebsd-current , Pawel Jakub Dawidek Subject: Re: [CFC/CFT] large changes in the loader(8) code X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2012 11:31:44 -0000 on 16/07/2012 14:14 Andrey V. Elsukov said the following: > On 16.07.2012 15:05, Andriy Gapon wrote: >>>> 2. I am not sure if I like the approach of moving partition tasting code into >>>> common ZFS code (zfs.c). On one hand, it now makes sense because the new >>>> partition iteration code is machine-independent. On the other hand, the reason >>>> that I added arch_zfs_probe method was to give platforms full control over which >>>> partitions and in what order are probed. It seems to be important for some of them. >>>> So, I like how your new partition interface makes it much easier to ZFS-probe >>>> partitions, but I would prefer to have that code in arch_zfs_probe implementations >>>> rather than in zfs_probe_dev. >>> >>> From the other point of view, ZFS is not a just file system and it works >>> directly with disks and partitions. And it seems to me this code will be common >>> for other architectures. >> >> Well, it seems that you haven't yet touched sparc64_zfs_probe. > > Yes. It should work as before. Well, but it's obvious that zfs_probe_dev would be attempting to do some unneeded stuff (trying to treat partitions as disks) for that case. To me this is a clear indication zfs_probe_dev is not optimal for arch-independent implementation. So I still think that arch_zfs_probe should decide what disks and partitions to probe, and zfs_probe_dev should only probe what it's given and not try to be any smarter. But I've repeated myself three times already :-) > But if Marius can suggest how to change ofw_disk.c to get disk size and sector size, > then i will be able to break something here :) > >> If you'll find that you don't have to use any ugly hacks there, then good. >> But my impression is that it would be easier to stick to the previous approach. > -- Andriy Gapon