From owner-svn-ports-head@freebsd.org Sat Feb 13 22:47:22 2021 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9CEB153DFE7; Sat, 13 Feb 2021 22:47:22 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DdQVK5Xldz3gyN; Sat, 13 Feb 2021 22:47:21 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id 4BEDD33ED3; Sat, 13 Feb 2021 17:47:15 -0500 (EST) Received: from [192.168.1.5] (77.118.111.172.wireless.dyn.drei.com [77.118.111.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id 6332733E9B; Sat, 13 Feb 2021 17:47:14 -0500 (EST) Date: Sat, 13 Feb 2021 23:47:12 +0100 (CET) From: Gerald Pfeifer To: Jan Beich , Rebecca Cran cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r511727 - head/sysutils/uefi-edk2-qemu In-Reply-To: Message-ID: <704b6093-69e0-57aa-c56b-33b558dd32ad@pfeifer.com> References: <201909100151.x8A1pqC5086268@repo.freebsd.org> <1746825a-d196-9390-6c71-45918862e985@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4DdQVK5Xldz3gyN X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of gerald@pfeifer.com designates 209.68.5.143 as permitted sender) smtp.mailfrom=gerald@pfeifer.com X-Spamd-Result: default: False [-3.29 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.68.5.143:from]; FREEFALL_USER(0.00)[gerald]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+a:hamza.pair.com]; ARC_NA(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; SPAMHAUS_ZRD(0.00)[209.68.5.143:from:127.0.2.255]; RCVD_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[pfeifer.com]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.985]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[svn-ports-all,svn-ports-head] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Feb 2021 22:47:22 -0000 On Wed, 11 Sep 2019, Jan Beich wrote: > Rebecca Cran writes: >>> Only lang/gcc (meta port) installs "gcc" symlink. Why not keep USE_GCC >>> while using the same hack as sysutils/uefi-edk2-bhyve or misc/seabios? >> Oh, I see the problem. It should be >> gcc${GCC_DEFAULT}:lang/gcc${GCC_DEFAULT}. >> >> I'm not sure what hack you're referring to: how do those ports avoid >> pulling in gcc as a dependency while still using USE_GCC? > USE_GCC= yes > ... > .include > RUN_DEPENDS:= ${RUN_DEPENDS:Ngcc*} Even better -- and I am sorry it took me so long to get this into the ports infrastructure (Mk/bsd.gcc.mk) -- should be a simple USE_GCC=yes:build This essentially is a variation of what Jan proposed, just with the new ":build" parameter instead of manipulating RUN_DEPENDS directly. Okay to commit? Gerald Index: Makefile =================================================================== --- Makefile (revision 565069) +++ Makefile (working copy) @@ -13,7 +13,6 @@ BUILD_DEPENDS= bash:shells/bash \ nasm:devel/nasm \ - gcc${GCC_DEFAULT}:lang/gcc${GCC_DEFAULT} \ ${PYTHON_PKGNAMEPREFIX}sqlite3>=2.7:databases/py-sqlite3@${PY_FLAVOR} FLAVORS= x86_64 i386 @@ -20,6 +19,7 @@ USES= gmake \ python:3.4+,build +USE_GCC= yes:build x86_64_PKGNAMESUFFIX= -x86_64 i386_PKGNAMESUFFIX= -i386