From owner-svn-src-all@FreeBSD.ORG Fri Jun 20 01:50:25 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C3B618C6; Fri, 20 Jun 2014 01:50:25 +0000 (UTC) Received: from mail-yk0-x235.google.com (mail-yk0-x235.google.com [IPv6:2607:f8b0:4002:c07::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 58755216F; Fri, 20 Jun 2014 01:50:25 +0000 (UTC) Received: by mail-yk0-f181.google.com with SMTP id 9so2219456ykp.12 for ; Thu, 19 Jun 2014 18:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=MEEPqQ+2UH5MXxl4n9lzn+cc4d1lnK6gGqiWMAHgMbE=; b=fy/begtJxcjY7iytptOGH046NUeJwNrzJ4gAtEKA0SgoKIknqy5ZoprIS3N7tkaC5e EpnIurZSorTFRHJyMkmaXqO0pwX+z76WRd0XCcVOK1TX8BDCAUrUCNZO+TFsZ26S79FY JJ+nYt/Wt8/H12s5r1N+QzaafeXoxO5vwUw5EZmn3NqkGEhZtQcuVJ016jbKo/wLJYbM HIcggsmCD6ty4eIdFbGo2OEbos6NLFf/cAyTNpgddRD3k4w0+tYEfdO3ziLAuLSr0+1p T2L9yys9VgdXZu2Dc79pdvMhAAMsSweiYar78SP8XYSemLe7ewVzBPuPPgdT4nnMcoYm HreA== X-Received: by 10.236.101.198 with SMTP id b46mr459242yhg.68.1403229024608; Thu, 19 Jun 2014 18:50:24 -0700 (PDT) Received: from zhabar.att.net (107-222-186-3.lightspeed.sntcca.sbcglobal.net. [107.222.186.3]) by mx.google.com with ESMTPSA id d46sm12006928yha.10.2014.06.19.18.50.23 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Thu, 19 Jun 2014 18:50:24 -0700 (PDT) Date: Thu, 19 Jun 2014 18:50:20 -0700 From: Justin Hibbits To: Alexander Kabaev Subject: Re: svn commit: r267660 - head/sys/dev/firewire Message-ID: <20140619185020.428a102d@zhabar.att.net> In-Reply-To: <201406200145.s5K1j3TC083304@svn.freebsd.org> References: <201406200145.s5K1j3TC083304@svn.freebsd.org> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.22; powerpc64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jun 2014 01:50:25 -0000 On Fri, 20 Jun 2014 01:45:03 +0000 (UTC) Alexander Kabaev wrote: > Author: kan > Date: Fri Jun 20 01:45:03 2014 > New Revision: 267660 > URL: http://svnweb.freebsd.org/changeset/base/267660 > > Log: > Set target->sbp field to valid value when sbp device is created. > > The sbp_cam_detach_target can be called from sbp_post_explore > function on the first target that is not really attached and it was > written with the corresponding safety check in place to tolerate > that. Unfortunately the recent locking cleanup did add a locking > assertion that tries to dereference the target->sbp pointer > unconditionally, which causes less than desirable outcome. Since the > assertion is useful, just initialize the target sbp pointer once when > sbp device is being initialized instead of when the target is being > attached. This makes assertion work in all cases and fixes the crash > on boot. Thanks for fixing this! I was hitting it on my latest kernel rebuilds, and kept rolling back until I could find the time to fix it. You beat me to it. - Justin