From owner-svn-src-projects@freebsd.org Sat Mar 2 20:31:52 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E44D7150E07F for ; Sat, 2 Mar 2019 20:31:51 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DB14681B96; Sat, 2 Mar 2019 20:31:50 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x62b.google.com with SMTP id b65so618940plb.6; Sat, 02 Mar 2019 12:31:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=eeD+ehhWD73Z7jNZxR3A3suuJbrZHQFnk+ncTKlAuq8=; b=QmuErqxbY265M5N4/rMFUgycoBO72LbUgzRhLoUZvnMyL+0WyslJE/QZqCvHc/7wy3 8KykVAcYEDbqlKdow2T+dHhO7uZFdcfMFGKx8IRhoUJ59fqfbuZt7WmlpA8zHj/GtPtp c5mdOU2dADeAAKOcWl4NfOvZZt6/MeGHA38j268OxIV5+YkfLCYmpG+MbVpoWLZEtGYm U7x02PnKxxfsP1HLGAbUc527co3yAIE5XKzfE1k4LMVqkBuTPv0+2X4wH3sOGv8BsDnG 9M3SbsT5J7nRPTHXXT0M85hcG8o1M0iT+dp6FLqeGuYtFxo6uddjQamLd9XllbqN8Eea lHGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=eeD+ehhWD73Z7jNZxR3A3suuJbrZHQFnk+ncTKlAuq8=; b=dKInNCNm+l47I94UvTWqJ4ClcqZytHDb0Gh09C2FZKplW81SGsmpsWkSXHItI4JowL Q1+Afjm3fawrWQrouxXNm4MHhBwbpKA7OlRA/I1oePNuTAqRFQGb+YlRYMENnx/iYUI/ 9ttk7Kdz23vQ6EADbaVauPyvrznn5IFnEkAAemfuFYu+XbG2LWHODOdsumkb7aozcGYA DTBupjjD2G4xceRC4tEh3GMa8j1HYgbz61lR1Tm+UiP4q3mOZI+rpyH/jHd1u+rLg93c e93aqng5Nrh/PmyyTPVht31NEv2RPYUAyYVPKBDjzj2bWrE9zFJ8gVP6VBbJzuGGwOok p9RQ== X-Gm-Message-State: APjAAAU4+5sgCtsXNt9GEn2STDj68L3zXJXzn2J7gh7ep/MSrmc9VPaP +Ut4AMMqPIFxWnbJmdKM3ExwgwCG X-Google-Smtp-Source: APXvYqzewiBEVgZBrwD70YbVHHik/6n+uASDe5mpMujWShkmSeVaLzdGmrG5PPqJ0PtbbIkQIojaDA== X-Received: by 2002:a17:902:bd87:: with SMTP id q7mr11985688pls.227.1551558709500; Sat, 02 Mar 2019 12:31:49 -0800 (PST) Received: from [192.168.20.21] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id a24sm2230564pfn.85.2019.03.02.12.31.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Mar 2019 12:31:48 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r344727 - projects/fuse2/tests/sys/fs/fuse From: "Enji Cooper (yaneurabeya)" In-Reply-To: Date: Sat, 2 Mar 2019 12:31:48 -0800 Cc: src-committers , svn-src-projects@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201903021628.x22GSTTV073206@repo.freebsd.org> To: Alan Somers X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: DB14681B96 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=QmuErqxb; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::62b as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-6.39 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-2.90)[ip: (-9.68), ipnet: 2607:f8b0::/32(-2.72), asn: 15169(-2.04), country: US(-0.07)]; RCVD_IN_DNSWL_NONE(0.00)[b.2.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0] X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Mar 2019 20:31:52 -0000 > On Mar 2, 2019, at 11:38, Enji Cooper (yaneurabeya) = wrote: >=20 >=20 >> On Mar 2, 2019, at 08:28, Alan Somers wrote: =E2=80=A6 >> Oddly, it's not possible to skip a test in any other way. I want to highlight this sentence a bit. It=E2=80=99s possible to skip test cases by prefixing them with = `DISABLED_` =E2=80=94 which you can then ignore when rerunning the test = program via `=E2=80=94gtest_also_run_disabled_tests`. However, you can = actually skip tests at runtime via the `GTEST_SKIP()` macro, as well, = which in combination with `SetupEnvironment(..)` is probably the most = correct way to handle prerequisites not being met at runtime. HTH, -Enji=