Date: Wed, 21 Oct 2009 23:19:51 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Remko Lodder <remko@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r198316 - head/sbin/tunefs Message-ID: <20091021222805.I12783@delplex.bde.org> In-Reply-To: <200910211015.n9LAFQwY094532@svn.freebsd.org> References: <200910211015.n9LAFQwY094532@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 21 Oct 2009, Remko Lodder wrote: > Log: > The tunefs utility does not work on active filesystems. Er, that's what it already said. Now it says less. Except, it is implicit in the statement being in the BUGS section that it is a bug for tunefs to not work on active file systems, just like it used to be implicit that tunefs did not work on active file systems. > Modified: head/sbin/tunefs/tunefs.8 > ============================================================================== > --- head/sbin/tunefs/tunefs.8 Wed Oct 21 09:53:55 2009 (r198315) > +++ head/sbin/tunefs/tunefs.8 Wed Oct 21 10:15:26 2009 (r198316) > @@ -28,7 +28,7 @@ > .\" @(#)tunefs.8 8.2 (Berkeley) 12/11/93 > .\" $FreeBSD$ > .\" > -.Dd August 13, 2007 > +.Dd October 21, 2009 It should have worked (but did not) on August 13 2007 too. > .Dt TUNEFS 8 > .Os > .Sh NAME > @@ -165,7 +165,7 @@ The > utility appeared in > .Bx 4.2 . > .Sh BUGS > -This utility should work on active file systems. > +This utility does not work on active file systems. It still should work (but does not). Except, it does work in some cases... > To change the root file system, the system must be rebooted > after the file system is tuned. > .\" Take this out and a Unix Daemon will dog your steps from now until ... this man page has not caught up with the changes in 1999 that made tunefs work on active file systems that are mounted read-only, or even with the 1995 changes that added -p (-p should work on active file systems, and I think it always did). So it is now literally wrong to say that tunefs does not work at all on active file systems, while saying that it should remains correct. What actually works is just undocumented for the second and misdocumented for the first. Also, error handling for the cases that don't work is obscure. Its error message doesn't mention mounted file systems and now doesn't even mention the EBUSY error at the failure point. This is fixed in my version. I haven't touched the man page. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091021222805.I12783>