From owner-cvs-src@FreeBSD.ORG Wed Aug 27 20:20:34 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E9E8216A4BF; Wed, 27 Aug 2003 20:20:34 -0700 (PDT) Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7FD9A43FEC; Wed, 27 Aug 2003 20:20:33 -0700 (PDT) (envelope-from jroberson@chesapeake.net) Received: from localhost (jroberson@localhost) by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id h7S3KVd52486; Wed, 27 Aug 2003 23:20:31 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Wed, 27 Aug 2003 23:20:31 -0400 (EDT) From: Jeff Roberson To: Marcel Moolenaar In-Reply-To: <20030828031421.GA7763@athlon.pn.xcllnt.net> Message-ID: <20030827231807.I12093-100000@mail.chesapeake.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/specfs spec_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2003 03:20:35 -0000 On Wed, 27 Aug 2003, Marcel Moolenaar wrote: > On Wed, Aug 27, 2003 at 10:55:13PM -0400, Jeff Roberson wrote: > > On Wed, 27 Aug 2003, Marcel Moolenaar wrote: > > > > > marcel 2003/08/27 18:52:14 PDT > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/fs/specfs spec_vnops.c > > > Log: > > > The valid field in struct vm_page can be of type unsigned long when > > > 32K pages are selected. In spec_getpages() change the printf format > > > specifier and add an explicit cast so that we always print the field > > > as a long type. > > > > > > Revision Changes Path > > > 1.209 +2 -2 src/sys/fs/specfs/spec_vnops.c > > > > Are you aware of the UMA problems with 32k pages? > > No, what are the problems? > It uses an 8 bit index to identify individual items in a slab. This is to save space in place of the full pointer that is used in traditional slab allocators. With an 8 bit index your smallest allocation on 4k pages is 16 bytes and 32 bytes on 8k. It'd be 128 bytes on 32k. You're going to have to conditionally compile UMA with 16bit indexes. Cheers, Jeff