From owner-cvs-all@FreeBSD.ORG  Sat Nov 15 12:11:46 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 62CA316A4CE
	for <cvs-all@FreeBSD.org>; Sat, 15 Nov 2003 12:11:46 -0800 (PST)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 96BB243FCB
	for <cvs-all@FreeBSD.org>; Sat, 15 Nov 2003 12:11:44 -0800 (PST)
	(envelope-from nate@rootlabs.com)
Received: (qmail 54515 invoked by uid 1000); 15 Nov 2003 20:11:45 -0000
Date: Sat, 15 Nov 2003 12:11:45 -0800 (PST)
From: Nate Lawson <nate@root.org>
To: Andre Oppermann <andre@FreeBSD.org>
In-Reply-To: <20031115170411.6330416A4E9@hub.freebsd.org>
Message-ID: <20031115121034.K54473@root.org>
References: <20031115170411.6330416A4E9@hub.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/netinet ip_fastfwd.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Nov 2003 20:11:46 -0000

On Sat, 15 Nov 2003, Andre Oppermann wrote:
>   Modified files:
>     sys/netinet          ip_fastfwd.c
>   Log:
>   Correct a cast to make it compile on 64bit platforms (noticed by tinderbox)
>   and remove two unneccessary variable initializations.
>   Make the introduction comment more clear with regard which parts of
>   the packet are touched.
>
>   Requested by:   luigi
>
>   Revision  Changes    Path
>   1.2       +6 -6      src/sys/netinet/ip_fastfwd.c
>
> --- src/sys/netinet/ip_fastfwd.c:1.1	Fri Nov 14 13:02:21 2003
> +++ src/sys/netinet/ip_fastfwd.c	Sat Nov 15 09:03:37 2003
> @@ -567,7 +567,7 @@
>  					goto drop;
>  				}
>  				tag->m_flags = PACKET_TAG_DIVERT;
> -				tag->m_data = (caddr_t)(u_int32_t)args.divert_rule;
> +				tag->m_data = (caddr_t)(u_long)args.divert_rule;
>  				tag->m_next = m;
>  				/* XXX: really bloody hack, see ip_input */
>  				tag->m_nextpkt = (struct mbuf *)1;

I believe this cast is still bogus.  You want uintptr_t.

-Nate