Date: Tue, 14 Apr 2009 20:28:09 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Ed Schouten <ed@80386.nl> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: Revert unneeded changes of r190919 Message-ID: <20090414202138.O53192@delplex.bde.org> In-Reply-To: <20090413161812.GD32098@hoeg.nl> References: <200904111401.n3BE1108088009@svn.freebsd.org> <20090413161812.GD32098@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 13 Apr 2009, Ed Schouten wrote: > Because the changes in r190919 did contain some nice fixes, but some of > them were unneeded or should not attempted to be fixed here, I've > decided to prepare a commit to revert the changes made in r190919, > except the improvements Christoph made to the inline assembly. > > http://80386.nl/pub/cmallon.diff Review of what I can quote easily in mail: this url appears to be syntactically correct. This is OK, but I would prefer to use temporary hacks in machdep.c than to mess up cpufunc.h with macros. Temporary until machdep.c is done right. In one right version, a file other than machdep.c would provide all the functions in cpufunc.h as extern functions callable by ddb, and _all_ the functions in cpufunc.h certainly shouldn't be messed up with macros. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090414202138.O53192>