Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 8 Mar 2019 19:07:42 +0000 (UTC)
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r344932 - stable/12/sys/net
Message-ID:  <201903081907.x28J7g6K063651@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jhb
Date: Fri Mar  8 19:07:41 2019
New Revision: 344932
URL: https://svnweb.freebsd.org/changeset/base/344932

Log:
  MFC 343620: Don't set IFCAP_TXRTLMT during lagg_clone_create().
  
  lagg_capabilities() will set the capability once interfaces supporting
  the feature are added to the lagg.  Setting it on a lagg without any
  interfaces is pointless as the if_snd_tag_alloc call will always fail
  in that case.

Modified:
  stable/12/sys/net/if_lagg.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/net/if_lagg.c
==============================================================================
--- stable/12/sys/net/if_lagg.c	Fri Mar  8 19:03:28 2019	(r344931)
+++ stable/12/sys/net/if_lagg.c	Fri Mar  8 19:07:41 2019	(r344932)
@@ -514,10 +514,8 @@ lagg_clone_create(struct if_clone *ifc, int unit, cadd
 	ifp->if_flags = IFF_SIMPLEX | IFF_BROADCAST | IFF_MULTICAST;
 #ifdef RATELIMIT
 	ifp->if_snd_tag_alloc = lagg_snd_tag_alloc;
-	ifp->if_capenable = ifp->if_capabilities = IFCAP_HWSTATS | IFCAP_TXRTLMT;
-#else
-	ifp->if_capenable = ifp->if_capabilities = IFCAP_HWSTATS;
 #endif
+	ifp->if_capenable = ifp->if_capabilities = IFCAP_HWSTATS;
 
 	/*
 	 * Attach as an ordinary ethernet device, children will be attached



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903081907.x28J7g6K063651>