Date: Tue, 17 Jan 2012 18:40:13 -0800 From: Devin Teske <devin.teske@fisglobal.com> To: "'Garrett Cooper'" <yanegomi@gmail.com> Cc: freebsd-hackers@freebsd.org Subject: RE: 14 month old regression (how?) Message-ID: <03b501ccd58a$81f211b0$85d63510$@fisglobal.com> In-Reply-To: <CAGH67wRMXQmFETLKXwQ5Ctn6F0J3=ouY88CdTmdoDrczSyhLQQ@mail.gmail.com> References: <03b301ccd587$eba40d00$c2ec2700$@fisglobal.com> <CAGH67wRMXQmFETLKXwQ5Ctn6F0J3=ouY88CdTmdoDrczSyhLQQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> -----Original Message-----
> From: Garrett Cooper [mailto:yanegomi@gmail.com]
> Sent: Tuesday, January 17, 2012 6:29 PM
> To: Devin Teske
> Cc: freebsd-hackers@freebsd.org
> Subject: Re: 14 month old regression (how?)
>
> On Tue, Jan 17, 2012 at 6:21 PM, Devin Teske <devin.teske@fisglobal.com>
> wrote:
> > Looking at bin/164192...
> >
> > I'm left wondering to myself...
> > How on Earth did a regression-by-typo introduced in SVN r214735 go 14
> > months without being noticed?
>
> Very carefully. I've seen it happen before on paid products (in fact I've
fixed 15
> year old bugs thanks to my colorized editor, and I'm sure someone's going to
find
> bugs I've made 1, 5, 10, or 20 years in the future..).. people make mistakes
-- it's a
> fact of life.
> -Garrett
I found the reason why this typo wasn't noticed.
Appears that "${WPA_DISTDIR}/src/crypto" is already being declared one-level-up
in the following file:
src/usr.sbin/wpa/Makefile.inc
Otherwise, buildworld would have failed in src/usr.sbin/wpa/wpa_supplicant
complaining about undefined references while linking wpa_supplicant.
The patch in bin/164192 still stands, but I'm going to amend the PR to explain
why this typo went unnoticed for 14 months.
--
Devin
_____________
The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?03b501ccd58a$81f211b0$85d63510$>