From owner-svn-ports-head@freebsd.org  Sat Sep  1 14:33:30 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E9F16FF1071;
 Sat,  1 Sep 2018 14:33:29 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 9E8A08DF62;
 Sat,  1 Sep 2018 14:33:29 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 9383F15759; Sat,  1 Sep 2018 14:33:29 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Tobias Kortkamp <tobik@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r478679 - head/devel/boost-python-libs
References: <201809011239.w81CdN2E020942@repo.freebsd.org>
 <1535807532.607241.1493457672.6296710D@webmail.messagingengine.com>
Date: Sat, 01 Sep 2018 16:33:25 +0200
Message-ID: <sh2t-qocq-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 01 Sep 2018 14:33:30 -0000

Tobias Kortkamp <tobik@FreeBSD.org> writes:

> On Sat, Sep 1, 2018, at 14:39, Jan Beich wrote:
>
>> Author: jbeich
>> Date: Sat Sep  1 12:39:23 2018
>> New Revision: 478679
>> URL: https://svnweb.freebsd.org/changeset/ports/478679
>> 
>> Log:
>>   devel/boost-python-libs: unbreak in C++17 mode
>>   
>>   In file included from libs/python/src/converter/from_python.cpp:6:
>>   In file included from ./boost/python/converter/from_python.hpp:8:
>>   In file included from ./boost/python/detail/prefix.hpp:13:
>>   In file included from ./boost/python/detail/wrap_python.hpp:151:
>>   In file included from /usr/local/include/python2.7/Python.h:88:
>>   /usr/local/include/python2.7/unicodeobject.h:534:5: error: ISO C++17 
>> does not allow 'register' storage class specifier [-Wregister]
>>       register PyObject *obj,     /* Object */
>>       ^~~~~~~~~
>>   /usr/local/include/python2.7/unicodeobject.h:553:5: error: ISO C++17 
>> does not allow 'register' storage class specifier [-Wregister]
>>       register PyObject *obj      /* Object */
>>       ^~~~~~~~~
>>   /usr/local/include/python2.7/unicodeobject.h:575:5: error: ISO C++17 
>> does not allow 'register' storage class specifier [-Wregister]
>>       register const wchar_t *w,  /* wchar_t buffer */
>>       ^~~~~~~~~
>>   /usr/local/include/python2.7/unicodeobject.h:593:5: error: ISO C++17 
>> does not allow 'register' storage class specifier [-Wregister]
>>       register wchar_t *w,        /* wchar_t buffer */
>>       ^~~~~~~~~
>
> Should we just patch lang/python27 to remove 'register' here instead
> of having to patch various ports now and in the future?  AFAIUI
> 'register' is quite useless nowadays.

Maybe[1] but Clang is too pedantic about C++.

-I vs. -isystem is a common issue many projects ignore, not just due to
warnings in dependencies but also include order (e.g., bug 159831,
193187). boost-python-libs doesn't call python2.7-config --cflags,
so it probably cannot blame python27 for using -I.

[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231073