Date: Mon, 23 May 2005 17:30:10 +1000 From: Peter Jeremy <PeterJeremy@optushome.com.au> To: Damien Bergamini <damien.bergamini@free.fr> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/ipw if_ipw.c Message-ID: <20050523073009.GQ2129@cirb503493.alcatel.com.au> In-Reply-To: <006a01c55f01$46851520$0100a8c0@bigbang> References: <200505221831.j4MIV8lq072154@repoman.freebsd.org> <4290D2ED.6080602@errno.com> <006a01c55f01$46851520$0100a8c0@bigbang>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2005-May-22 21:05:48 +0200, Damien Bergamini wrote: >>Why? A good freebsd commit msg explains why you make a change. > >Basically because the Linux driver does it and because some users >reported that this fixes issues with ACPI. Remember that I have >zero documentation for this chipset except the Linux driver itself >which is very poorly commented. And Intel refuses to answer to >any technical question regarding the hardware. Can I suggest that this is close to the sort of information that should be included in this sort of commit message. As an example: A number of people have reported [describe type of problem] with suspend/resume using this chipset. Technical documentation is not available but Linux uses this fix/work-around and it seems to also fix/hide the problem on FreeBSD. There should probably be something similar as a comment in the code. IMHO, this is worth a further commit (either including some comments in the code or as a forced commit). Otherwise the next person to look at the driver will wonder what's going on. -- Peter Jeremy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050523073009.GQ2129>