From owner-cvs-all@FreeBSD.ORG Mon May 23 07:31:04 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7CA8116A41C; Mon, 23 May 2005 07:31:04 +0000 (GMT) (envelope-from PeterJeremy@optushome.com.au) Received: from mail03.syd.optusnet.com.au (mail03.syd.optusnet.com.au [211.29.132.184]) by mx1.FreeBSD.org (Postfix) with ESMTP id E133F43D1F; Mon, 23 May 2005 07:31:03 +0000 (GMT) (envelope-from PeterJeremy@optushome.com.au) Received: from cirb503493.alcatel.com.au (c211-30-75-229.belrs2.nsw.optusnet.com.au [211.30.75.229]) by mail03.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id j4N7UBVT026560 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Mon, 23 May 2005 17:30:58 +1000 Received: from cirb503493.alcatel.com.au (localhost.alcatel.com.au [127.0.0.1]) by cirb503493.alcatel.com.au (8.12.10/8.12.10) with ESMTP id j4N7UARx012597; Mon, 23 May 2005 17:30:11 +1000 (EST) (envelope-from pjeremy@cirb503493.alcatel.com.au) Received: (from pjeremy@localhost) by cirb503493.alcatel.com.au (8.12.10/8.12.9/Submit) id j4N7UAhJ012596; Mon, 23 May 2005 17:30:10 +1000 (EST) (envelope-from pjeremy) Date: Mon, 23 May 2005 17:30:10 +1000 From: Peter Jeremy To: Damien Bergamini Message-ID: <20050523073009.GQ2129@cirb503493.alcatel.com.au> References: <200505221831.j4MIV8lq072154@repoman.freebsd.org> <4290D2ED.6080602@errno.com> <006a01c55f01$46851520$0100a8c0@bigbang> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <006a01c55f01$46851520$0100a8c0@bigbang> User-Agent: Mutt/1.4.2i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/ipw if_ipw.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2005 07:31:04 -0000 On Sun, 2005-May-22 21:05:48 +0200, Damien Bergamini wrote: >>Why? A good freebsd commit msg explains why you make a change. > >Basically because the Linux driver does it and because some users >reported that this fixes issues with ACPI. Remember that I have >zero documentation for this chipset except the Linux driver itself >which is very poorly commented. And Intel refuses to answer to >any technical question regarding the hardware. Can I suggest that this is close to the sort of information that should be included in this sort of commit message. As an example: A number of people have reported [describe type of problem] with suspend/resume using this chipset. Technical documentation is not available but Linux uses this fix/work-around and it seems to also fix/hide the problem on FreeBSD. There should probably be something similar as a comment in the code. IMHO, this is worth a further commit (either including some comments in the code or as a forced commit). Otherwise the next person to look at the driver will wonder what's going on. -- Peter Jeremy