Date: Tue, 11 Sep 2001 04:46:51 -0400 (EDT) From: "Andrew R. Reiter" <arr@watson.org> To: Ruslan Ermilov <ru@FreeBSD.ORG> Cc: freebsd-audit@FreeBSD.ORG Subject: Re: select diffs Message-ID: <Pine.NEB.3.96L.1010911044302.47624A-300000@fledge.watson.org> In-Reply-To: <20010911102900.C4979@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-1615358615-1000198011=:47624 Content-Type: TEXT/PLAIN; charset=US-ASCII Ahh yes, I knew this would happen :-) Mike said the same thing -- I cringed since I had just done the entire update without a rcs and sent the patch anyway. Nevertheless, I have the two patches done (and attached). The first (rlogin.c.1.diff) does the style(9) changes... Mike was key in pointing out numerous problems. The second (rlogin.c.2.diff) does the select changes -- dynamic allocation of fd_set bit arrays. Let me know if I missed something in turning it into 2 diffs. thanks, Andrew On Tue, 11 Sep 2001, Ruslan Ermilov wrote: :On Tue, Sep 11, 2001 at 02:05:32AM -0400, Andrew R. Reiter wrote: :> :> Thanks to Mike Barcroft for some comments and beating my style(9) :> skillessness (word?) into helping to clean rlogind.c. :> :> Attached is an updated diff for the select "problems" as well as updates :> to rlogind.c to clean it up in terms of style(9). If I missed something, :> tips are appreciated -- Im a style(9) retard, to be politically incorrect. :> :> Sorry that it's not 2 diffs, one for select and one for style(9) fixes, :> but such is life. :> :Please don't mix style and functionality fixes!!! :These are at least hard to review. : : :Cheers, :-- :Ruslan Ermilov Oracle Developer/DBA, :ru@sunbay.com Sunbay Software AG, :ru@FreeBSD.org FreeBSD committer, :+380.652.512.251 Simferopol, Ukraine : :http://www.FreeBSD.org The Power To Serve :http://www.oracle.com Enabling The Information Age : *-------------................................................. | Andrew R. Reiter | arr@fledge.watson.org | "It requires a very unusual mind | to undertake the analysis of the obvious" -- A.N. Whitehead --0-1615358615-1000198011=:47624 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="rlogind.c.1.diff" Content-Transfer-Encoding: BASE64 Content-ID: <Pine.NEB.3.96L.1010911044651.47624B@fledge.watson.org> Content-Description: LS0tIHJsb2dpbmQuYy5vcmlnCU1vbiBTZXAgMTAgMjI6MzI6MjggMjAwMQ0K KysrIHJsb2dpbmQuYwlUdWUgU2VwIDExIDAzOjMwOjQyIDIwMDENCkBAIC03 OCw2ICs3OCw3IEBADQogI2luY2x1ZGUgPHN0ZGxpYi5oPg0KICNpbmNsdWRl IDxzdHJpbmcuaD4NCiAjaW5jbHVkZSA8dW5pc3RkLmg+DQorDQogI2luY2x1 ZGUgInBhdGhuYW1lcy5oIg0KIA0KIA0KQEAgLTEwMyw2ICsxMDQsMTUgQEAN CiANCiBzdHJ1Y3QJcGFzc3dkICpwd2Q7DQogDQoraW50CWNoaWxkOw0KK2lu dAluZXRmOw0KK2NoYXIJbGluZVtNQVhQQVRITEVOXTsNCitpbnQJY29uZmly bWVkOw0KK3N0cnVjdCB3aW5zaXplIHdpbiA9IHsgMCwgMCwgMCwgMCB9Ow0K Kw0KK2NoYXIJbWFnaWNbMl0gPSB7IDAzNzcsIDAzNzcgfTsNCitjaGFyCW9v YmRhdGFbXSA9IHtUSU9DUEtUX1dJTkRPV307DQorDQogdW5pb24gc29ja3Vu aW9uIHsNCiAJc3RydWN0IHNvY2tpbmV0IHsNCiAJCXVfY2hhciBzaV9sZW47 DQpAQCAtMTY3LDcgKzE3Nyw3IEBADQogCWFyZ2MgLT0gb3B0aW5kOw0KIAlh cmd2ICs9IG9wdGluZDsNCiANCi0JZnJvbWxlbiA9IHNpemVvZiAoZnJvbSk7 DQorCWZyb21sZW4gPSBzaXplb2YoZnJvbSk7DQogCWlmIChnZXRwZWVybmFt ZSgwLCAoc3RydWN0IHNvY2thZGRyICopJmZyb20sICZmcm9tbGVuKSA8IDAp IHsNCiAJCXN5c2xvZyhMT0dfRVJSLCJDYW4ndCBnZXQgcGVlciBuYW1lIG9m IHJlbW90ZSBob3N0OiAlbSIpOw0KIAkJZmF0YWwoU1RERVJSX0ZJTEVOTywg IkNhbid0IGdldCBwZWVyIG5hbWUgb2YgcmVtb3RlIGhvc3QiLCAxKTsNCkBA IC0xNzksMjQgKzE4OSwxNyBAQA0KIAlpZiAobm9fZGVsYXkgJiYNCiAJICAg IHNldHNvY2tvcHQoMCwgSVBQUk9UT19UQ1AsIFRDUF9OT0RFTEFZLCAmb24s IHNpemVvZihvbikpIDwgMCkNCiAJCXN5c2xvZyhMT0dfV0FSTklORywgInNl dHNvY2tvcHQgKFRDUF9OT0RFTEFZKTogJW0iKTsNCi0gICAgICAgIGlmIChm cm9tLnN1X2ZhbWlseSA9PSBBRl9JTkVUKQ0KLSAgICAgIHsNCi0Jb24gPSBJ UFRPU19MT1dERUxBWTsNCi0JaWYgKHNldHNvY2tvcHQoMCwgSVBQUk9UT19J UCwgSVBfVE9TLCAoY2hhciAqKSZvbiwgc2l6ZW9mKGludCkpIDwgMCkNCisg ICAgICAgIGlmIChmcm9tLnN1X2ZhbWlseSA9PSBBRl9JTkVUKSB7DQorCQlv biA9IElQVE9TX0xPV0RFTEFZOw0KKwkJaWYgKHNldHNvY2tvcHQoMCwgSVBQ Uk9UT19JUCwgSVBfVE9TLCAoY2hhciAqKSZvbiwgDQorICAgICAgICAgICAg ICAgICAgICBzaXplb2YoaW50KSkgPCAwKQ0KIAkJc3lzbG9nKExPR19XQVJO SU5HLCAic2V0c29ja29wdCAoSVBfVE9TKTogJW0iKTsNCi0gICAgICB9DQor ICAgICAgCX0NCiANCiAJZG9pdCgwLCAmZnJvbSk7DQogCXJldHVybiAwOw0K IH0NCiANCi1pbnQJY2hpbGQ7DQotaW50CW5ldGY7DQotY2hhcglsaW5lW01B WFBBVEhMRU5dOw0KLWludAljb25maXJtZWQ7DQotDQotc3RydWN0IHdpbnNp emUgd2luID0geyAwLCAwLCAwLCAwIH07DQotDQogDQogdm9pZA0KIGRvaXQo ZiwgZnJvbXApDQpAQCAtMjA4LDYgKzIxMSw5IEBADQogCWNoYXIgaG9zdG5h bWVbMiAqIE1BWEhPU1ROQU1FTEVOICsgMV07DQogCWNoYXIgbmFtZWluZm9b MiAqIElORVQ2X0FERFJTVFJMRU4gKyAxXTsNCiAJY2hhciBjOw0KKwl1X2No YXIgb3B0YnVmW0JVRlNJWi8zXSwgcywgcnJvcHRbNV0sIHJlbW90ZV9pcFsx Nl07DQorCWludCBvcHRzaXplID0gc2l6ZW9mKG9wdGJ1ZiksIGlwcHJvdG8s IGk7DQorCXN0cnVjdCBwcm90b2VudCAqaXA7DQogDQogCWFsYXJtKDYwKTsN CiAJcmVhZChmLCAmYywgMSk7DQpAQCAtMjE4LDM0ICsyMjQsMzUgQEANCiAJ YWxhcm0oMCk7DQogDQogCXJlYWxob3N0bmFtZV9zYShob3N0bmFtZSwgc2l6 ZW9mKGhvc3RuYW1lKSAtIDEsDQotCQkJICAgIChzdHJ1Y3Qgc29ja2FkZHIg Kilmcm9tcCwgZnJvbXAtPnN1X2xlbik7DQorCSAgICAoc3RydWN0IHNvY2th ZGRyICopZnJvbXAsIGZyb21wLT5zdV9sZW4pOw0KKwlob3N0bmFtZVtzaXpl b2YoaG9zdG5hbWUpIC0gMV0gPSAnXDAnOw0KIAkvKiBlcnJvciBjaGVjayA/ ICovDQorDQogCWZyb21wLT5zdV9wb3J0ID0gbnRvaHMoKHVfc2hvcnQpZnJv bXAtPnN1X3BvcnQpOw0KLQlob3N0bmFtZVtzaXplb2YoaG9zdG5hbWUpIC0g MV0gPSAnXDAnOw0KIA0KLQl7DQotCQlpZiAoKGZyb21wLT5zdV9mYW1pbHkg IT0gQUZfSU5FVA0KKwlpZiAoKGZyb21wLT5zdV9mYW1pbHkgIT0gQUZfSU5F VA0KICNpZmRlZiBJTkVUNg0KLQkJICAmJiBmcm9tcC0+c3VfZmFtaWx5ICE9 IEFGX0lORVQ2DQorICAgICAgICAgICAgJiYgIGZyb21wLT5zdV9mYW1pbHkg IT0gQUZfSU5FVDYNCiAjZW5kaWYNCi0JCSAgICAgKSB8fA0KLQkJICAgIGZy b21wLT5zdV9wb3J0ID49IElQUE9SVF9SRVNFUlZFRCB8fA0KLQkJICAgIGZy b21wLT5zdV9wb3J0IDwgSVBQT1JUX1JFU0VSVkVELzIpIHsNCi0JCQlnZXRu YW1laW5mbygoc3RydWN0IHNvY2thZGRyICopZnJvbXAsDQotCQkJCSAgICBm cm9tcC0+c3VfbGVuLA0KLQkJCQkgICAgbmFtZWluZm8sIHNpemVvZihuYW1l aW5mbyksIE5VTEwsIDAsDQotCQkJCSAgICBOSV9OVU1FUklDSE9TVHxOSV9X SVRIU0NPUEVJRCk7DQotCQkJLyogZXJyb3IgY2hlY2sgPyAqLw0KLQkJCXN5 c2xvZyhMT0dfTk9USUNFLCAiQ29ubmVjdGlvbiBmcm9tICVzIG9uIGlsbGVn YWwgcG9ydCIsDQotCQkJICAgICAgIG5hbWVpbmZvKTsNCi0JCQlmYXRhbChm LCAiUGVybWlzc2lvbiBkZW5pZWQiLCAwKTsNCi0JCX0NCisJICAgICkgfHwN CisJICAgIGZyb21wLT5zdV9wb3J0ID49IElQUE9SVF9SRVNFUlZFRCB8fA0K KwkgICAgZnJvbXAtPnN1X3BvcnQgPCBJUFBPUlRfUkVTRVJWRUQvMikgew0K KwkJZ2V0bmFtZWluZm8oKHN0cnVjdCBzb2NrYWRkciAqKWZyb21wLA0KKwkJ ICAgIGZyb21wLT5zdV9sZW4sDQorCQkgICAgbmFtZWluZm8sIHNpemVvZihu YW1laW5mbyksIE5VTEwsIDAsDQorCQkgICAgTklfTlVNRVJJQ0hPU1R8Tklf V0lUSFNDT1BFSUQpOw0KKwkJLyogZXJyb3IgY2hlY2sgPyAqLw0KKw0KKwkJ c3lzbG9nKExPR19OT1RJQ0UsICJDb25uZWN0aW9uIGZyb20gJXMgb24gaWxs ZWdhbCBwb3J0IiwNCisJICAgICAgICAgICAgbmFtZWluZm8pOw0KKwkJZmF0 YWwoZiwgIlBlcm1pc3Npb24gZGVuaWVkIiwgMCk7DQorCX0NCiAjaWZkZWYg SVBfT1BUSU9OUw0KLQkJaWYgKGZyb21wLT5zdV9mYW1pbHkgPT0gQUZfSU5F VCkNCi0gICAgICAgICAgICAgIHsNCi0JCXVfY2hhciBvcHRidWZbQlVGU0la LzNdOw0KLQkJaW50IG9wdHNpemUgPSBzaXplb2Yob3B0YnVmKSwgaXBwcm90 bywgaTsNCi0JCXN0cnVjdCBwcm90b2VudCAqaXA7DQorCWlmIChmcm9tcC0+ c3VfZmFtaWx5ID09IEFGX0lORVQpIHsNCisJCW1lbXNldChvcHRidWYsIDAs IEJVRlNJWi8zKTsNCisJCW9wdHNpemUgPSBzaXplb2Yob3B0YnVmKTsNCisg IAkJaXBwcm90byA9IGkgPSAwOw0KKwkJaXAgPSBOVUxMOw0KIA0KIAkJaWYg KChpcCA9IGdldHByb3RvYnluYW1lKCJpcCIpKSAhPSBOVUxMKQ0KIAkJCWlw cHJvdG8gPSBpcC0+cF9wcm90bzsNCkBAIC0yNTQsMzQgKzI2MSw0NiBAQA0K IAkJaWYgKGdldHNvY2tvcHQoMCwgaXBwcm90bywgSVBfT1BUSU9OUywgKGNo YXIgKilvcHRidWYsDQogCQkgICAgJm9wdHNpemUpID09IDAgJiYgb3B0c2l6 ZSAhPSAwKSB7DQogCQkJZm9yIChpID0gMDsgaSA8IG9wdHNpemU7ICkgew0K LQkJCQl1X2NoYXIgYyA9IG9wdGJ1ZltpXTsNCi0JCQkJaWYgKGMgPT0gSVBP UFRfTFNSUiB8fCBjID09IElQT1BUX1NTUlIpIHsNCisJCQkJcyA9IG9wdGJ1 ZltpXTsNCisJCQkJaWYgKHMgPT0gSVBPUFRfTFNSUiANCisJCQkJICAgIHx8 IHMgPT0gSVBPUFRfU1NSUikgew0KKwkJCQkJaWYgKHMgPT0gSVBPUFRfTFNS UikNCisJCQkJCQkodm9pZClzdHJsY3B5KHJyb3B0LCAiTFNSUiIsDQorCQkJ CQkgICAgCSAgICBzaXplb2YocnJvcHQpKTsNCisJCQkgCQllbHNlDQorCQkJ CQkJKHZvaWQpc3RybGNweShycm9wdCwgIlNTUlIiLA0KKwkJCQkJICAgIAkg ICAgc2l6ZW9mKHJyb3B0KSk7DQorDQorCQkJCQltZW1zZXQocmVtb3RlX2lw LCAwLCBzaXplb2YocmVtb3RlX2lwKSk7DQorCQkJCQkodm9pZClzdHJsY3B5 KHJlbW90ZV9pcCwNCisJCQkJICAgIAkgICAgaW5ldF9udG9hKGZyb21wLT5z dV9zaW4uc2luX2FkZHIpLA0KKwkJCQkgICAgCSAgICBzaXplb2YocmVtb3Rl X2lwKSk7DQorDQogCQkJCQlzeXNsb2coTE9HX05PVElDRSwNCi0JCQkJCQki Q29ubmVjdGlvbiByZWZ1c2VkIGZyb20gJXMgd2l0aCBJUCBvcHRpb24gJXMi LA0KLQkJCQkJCWluZXRfbnRvYShmcm9tcC0+c3Vfc2luLnNpbl9hZGRyKSwN Ci0JCQkJCQljID09IElQT1BUX0xTUlIgPyAiTFNSUiIgOiAiU1NSUiIpOw0K KwkJCQkgICAgCSAgICAiQ29ubmVjdGlvbiByZWZ1c2VkIGZyb20gJXMiDQor CQkJCSAgICAJICAgICIgd2l0aCBJUCBvcHRpb24gJXMiLA0KKwkJCQkgICAg CSAgICByZW1vdGVfaXAsIHJyb3B0KTsNCiAJCQkJCWV4aXQoMSk7DQogCQkJ CX0NCi0JCQkJaWYgKGMgPT0gSVBPUFRfRU9MKQ0KKwkJCQlpZiAocyA9PSBJ UE9QVF9FT0wpDQogCQkJCQlicmVhazsNCi0JCQkJaSArPSAoYyA9PSBJUE9Q VF9OT1ApID8gMSA6IG9wdGJ1ZltpKzFdOw0KKwkJCQlpICs9IChzID09IElQ T1BUX05PUCkgPyAxIDogb3B0YnVmW2krMV07DQogCQkJfQ0KIAkJfQ0KLQkg ICAgICB9DQorCX0NCiAjZW5kaWYNCi0JCWlmIChkb19ybG9naW4oZnJvbXAp ID09IDApDQorCWlmIChkb19ybG9naW4oZnJvbXApID09IDApDQogCQkJYXV0 aGVudGljYXRlZCsrOw0KLQl9DQogCWlmIChjb25maXJtZWQgPT0gMCkgew0K IAkJd3JpdGUoZiwgIiIsIDEpOw0KIAkJY29uZmlybWVkID0gMTsJCS8qIHdl IHNlbnQgdGhlIG51bGwhICovDQogCX0NCiAjaWZkZWYJQ1JZUFQNCiAJaWYg KGRvZW5jcnlwdCkNCi0JCSh2b2lkKSBkZXNfZW5jX3dyaXRlKGYsDQotCQkJ CSAgICAgU0VDVVJFX01FU1NBR0UsDQotCQkJCSAgICAgc3RybGVuKFNFQ1VS RV9NRVNTQUdFKSwNCi0JCQkJICAgICBzY2hlZHVsZSwgJmtkYXRhLT5zZXNz aW9uKTsNCisJCSh2b2lkKWRlc19lbmNfd3JpdGUoZiwNCisJCSAgICBTRUNV UkVfTUVTU0FHRSwNCisJCSAgICBzdHJsZW4oU0VDVVJFX01FU1NBR0UpLA0K KwkJICAgIHNjaGVkdWxlLCAma2RhdGEtPnNlc3Npb24pOw0KICNlbmRpZg0K IAluZXRmID0gZjsNCiANCkBAIC0yOTQsMTcgKzMxMywxNyBAQA0KIAl9DQog CWlmIChwaWQgPT0gMCkgew0KIAkJaWYgKGYgPiAyKQkvKiBmIHNob3VsZCBh bHdheXMgYmUgMCwgYnV0Li4uICovDQotCQkJKHZvaWQpIGNsb3NlKGYpOw0K KwkJCSh2b2lkKWNsb3NlKGYpOw0KIAkJc2V0dXBfdGVybSgwKTsNCi0JCSBp ZiAoKmx1c2VybmFtZT09Jy0nKSB7DQorCQlpZiAoKmx1c2VybmFtZSA9PSAn LScpIHsNCiAJCQlzeXNsb2coTE9HX0VSUiwgInRyaWVkIHRvIHBhc3MgdXNl ciBcIiVzXCIgdG8gbG9naW4iLA0KLQkJCSAgICAgICBsdXNlcm5hbWUpOw0K KwkJCSAgICBsdXNlcm5hbWUpOw0KIAkJCWZhdGFsKFNUREVSUl9GSUxFTk8s ICJpbnZhbGlkIHVzZXIiLCAwKTsNCiAJCX0NCi0JCWlmIChhdXRoZW50aWNh dGVkKSB7DQorCQlpZiAoYXV0aGVudGljYXRlZCkgDQogCQkJZXhlY2woX1BB VEhfTE9HSU4sICJsb2dpbiIsICItcCIsDQogCQkJICAgICItaCIsIGhvc3Ru YW1lLCAiLWYiLCBsdXNlcm5hbWUsIChjaGFyICopTlVMTCk7DQotCQl9IGVs c2UNCisJCWVsc2UNCiAJCQlleGVjbChfUEFUSF9MT0dJTiwgImxvZ2luIiwg Ii1wIiwNCiAJCQkgICAgIi1oIiwgaG9zdG5hbWUsIGx1c2VybmFtZSwgKGNo YXIgKilOVUxMKTsNCiAJCWZhdGFsKFNUREVSUl9GSUxFTk8sIF9QQVRIX0xP R0lOLCAxKTsNCkBAIC0zMjcsOCArMzQ2LDYgQEANCiAJY2xlYW51cCgwKTsN CiB9DQogDQotY2hhcgltYWdpY1syXSA9IHsgMDM3NywgMDM3NyB9Ow0KLWNo YXIJb29iZGF0YVtdID0ge1RJT0NQS1RfV0lORE9XfTsNCiANCiAvKg0KICAq IEhhbmRsZSBhICJjb250cm9sIiByZXF1ZXN0IChzaWduYWxlZCBieSBtYWdp YyBiZWluZyBwcmVzZW50KQ0KQEAgLTM2NiwxMyArMzgzLDE2IEBADQogCWlu dCBwY2MgPSAwLCBmY2MgPSAwOw0KIAlpbnQgY2MsIG5mZCwgbjsNCiAJY2hh ciBjbnRsOw0KKwlmZF9zZXQgaWJpdHMsIG9iaXRzLCBlYml0cywgKm9tYXNr Ow0KKwlyZWdpc3RlciBjaGFyICpjcDsNCisJaW50IGxlZnQsIG07DQogDQog CS8qDQogCSAqIE11c3QgaWdub3JlIFNJR1RUT1UsIG90aGVyd2lzZSB3ZSds bCBzdG9wDQogCSAqIHdoZW4gd2UgdHJ5IGFuZCBzZXQgc2xhdmUgcHR5J3Mg d2luZG93IHNoYXBlDQogCSAqIChvdXIgY29udHJvbGxpbmcgdHR5IGlzIHRo ZSBtYXN0ZXIgcHR5KS4NCiAJICovDQotCSh2b2lkKSBzaWduYWwoU0lHVFRP VSwgU0lHX0lHTik7DQorCSh2b2lkKXNpZ25hbChTSUdUVE9VLCBTSUdfSUdO KTsNCiAJc2VuZChmLCBvb2JkYXRhLCAxLCBNU0dfT09CKTsJLyogaW5kaWNh dGUgbmV3IHJsb2dpbiAqLw0KIAlpZiAoZiA+IHApDQogCQluZmQgPSBmICsg MTsNCkBAIC0zODIsMTMgKzQwMiwxMiBAQA0KIAkJc3lzbG9nKExPR19FUlIs ICJzZWxlY3QgbWFzayB0b28gc21hbGwsIGluY3JlYXNlIEZEX1NFVFNJWkUi KTsNCiAJCWZhdGFsKGYsICJpbnRlcm5hbCBlcnJvciAoc2VsZWN0IG1hc2sg dG9vIHNtYWxsKSIsIDApOw0KIAl9DQotCWZvciAoOzspIHsNCi0JCWZkX3Nl dCBpYml0cywgb2JpdHMsIGViaXRzLCAqb21hc2s7DQogDQorCWZvciAoOzsp IHsNCiAJCUZEX1pFUk8oJmViaXRzKTsNCiAJCUZEX1pFUk8oJmliaXRzKTsN CiAJCUZEX1pFUk8oJm9iaXRzKTsNCi0JCW9tYXNrID0gKGZkX3NldCAqKU5V TEw7DQorCQlvbWFzayA9IE5VTEw7DQogCQlpZiAoZmNjKSB7DQogCQkJRkRf U0VUKHAsICZvYml0cyk7DQogCQkJb21hc2sgPSAmb2JpdHM7DQpAQCAtNDI4 LDMwICs0NDcsMzAgQEANCiAjaWZkZWYJQ1JZUFQNCiAJCQlpZiAoZG9lbmNy eXB0KQ0KIAkJCQlmY2MgPSBkZXNfZW5jX3JlYWQoZiwgZmlidWYsIHNpemVv ZihmaWJ1ZiksDQotCQkJCQlzY2hlZHVsZSwgJmtkYXRhLT5zZXNzaW9uKTsN CisJCQkJICAgIHNjaGVkdWxlLCAma2RhdGEtPnNlc3Npb24pOw0KIAkJCWVs c2UNCiAjZW5kaWYNCiAJCQkJZmNjID0gcmVhZChmLCBmaWJ1Ziwgc2l6ZW9m KGZpYnVmKSk7DQogCQkJaWYgKGZjYyA8IDAgJiYgZXJybm8gPT0gRVdPVUxE QkxPQ0spDQogCQkJCWZjYyA9IDA7DQogCQkJZWxzZSB7DQotCQkJCXJlZ2lz dGVyIGNoYXIgKmNwOw0KLQkJCQlpbnQgbGVmdCwgbjsNCisJCQkJY3AgPSBO VUxMOw0KKwkJCQlsZWZ0ID0gbSA9IDA7DQogDQogCQkJCWlmIChmY2MgPD0g MCkNCiAJCQkJCWJyZWFrOw0KIAkJCQlmYnAgPSBmaWJ1ZjsNCi0NCiAJCQl0 b3A6DQogCQkJCWZvciAoY3AgPSBmaWJ1ZjsgY3AgPCBmaWJ1ZitmY2MtMTsg Y3ArKykNCiAJCQkJCWlmIChjcFswXSA9PSBtYWdpY1swXSAmJg0KIAkJCQkJ ICAgIGNwWzFdID09IG1hZ2ljWzFdKSB7DQotCQkJCQkJbGVmdCA9IGZjYyAt IChjcC1maWJ1Zik7DQorCQkJCQkJbGVmdCA9IGZjYyAtIChjcCAtIGZpYnVm KTsNCiAJCQkJCQluID0gY29udHJvbChwLCBjcCwgbGVmdCk7DQogCQkJCQkJ aWYgKG4pIHsNCiAJCQkJCQkJbGVmdCAtPSBuOw0KIAkJCQkJCQlpZiAobGVm dCA+IDApDQotCQkJCQkJCQliY29weShjcCtuLCBjcCwgbGVmdCk7DQorCQkJ CQkJCQliY29weShjcCtuLCANCisJCQkJCQkJCSAgICBjcCwgbGVmdCk7DQog CQkJCQkJCWZjYyAtPSBuOw0KIAkJCQkJCQlnb3RvIHRvcDsgLyogbl4yICov DQogCQkJCQkJfQ0KQEAgLTQ2OSw3ICs0ODgsNyBAQA0KIAkJfQ0KIA0KIAkJ aWYgKEZEX0lTU0VUKHAsICZpYml0cykpIHsNCi0JCQlwY2MgPSByZWFkKHAs IHBpYnVmLCBzaXplb2YgKHBpYnVmKSk7DQorCQkJcGNjID0gcmVhZChwLCBw aWJ1Ziwgc2l6ZW9mKHBpYnVmKSk7DQogCQkJcGJwID0gcGlidWY7DQogCQkJ aWYgKHBjYyA8IDAgJiYgZXJybm8gPT0gRVdPVUxEQkxPQ0spDQogCQkJCXBj YyA9IDA7DQpAQCAtNDkzLDcgKzUxMiw3IEBADQogI2lmZGVmCUNSWVBUDQog CQkJaWYgKGRvZW5jcnlwdCkNCiAJCQkJY2MgPSBkZXNfZW5jX3dyaXRlKGYs IHBicCwgcGNjLA0KLQkJCQkJc2NoZWR1bGUsICZrZGF0YS0+c2Vzc2lvbik7 DQorCQkJCSAgICBzY2hlZHVsZSwgJmtkYXRhLT5zZXNzaW9uKTsNCiAJCQll bHNlDQogI2VuZGlmDQogCQkJCWNjID0gd3JpdGUoZiwgcGJwLCBwY2MpOw0K QEAgLTU1Nyw3ICs1NzYsNyBAQA0KIAkJbGVuID0gc25wcmludGYoYnAsIHNp emVvZihidWYpLCAicmxvZ2luZDogJXMuXHJcbiIsIG1zZyk7DQogCWlmIChs ZW4gPCAwKQ0KIAkJbGVuID0gMDsNCi0JKHZvaWQpIHdyaXRlKGYsIGJ1Ziwg YnAgKyBsZW4gLSBidWYpOw0KKwkodm9pZCl3cml0ZShmLCBidWYsIGJwICsg bGVuIC0gYnVmKTsNCiAJZXhpdCgxKTsNCiB9DQogDQpAQCAtNTc2LDcgKzU5 NSw3IEBADQogCS8qIFhYWCB3aHkgZG9uJ3Qgd2Ugc3lzbG9nKCkgZmFpbHVy ZT8gKi8NCiANCiAJcmV0dXJuIChpcnVzZXJva19zYShkZXN0LCBkZXN0LT5z dV9sZW4sIHB3ZC0+cHdfdWlkID09IDAsIHJ1c2VybmFtZSwNCi0JCQkgICAg bHVzZXJuYW1lKSk7DQorCSAgICBsdXNlcm5hbWUpKTsNCiB9DQogDQogdm9p ZA0K --0-1615358615-1000198011=:47624 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="rlogind.c.2.diff" Content-Transfer-Encoding: BASE64 Content-ID: <Pine.NEB.3.96L.1010911044651.47624C@fledge.watson.org> Content-Description: LS0tIHJsb2dpbmQuYy5vcmlnCVR1ZSBTZXAgMTEgMDM6NDE6MzEgMjAwMQ0K KysrIHJsb2dpbmQuYwlUdWUgU2VwIDExIDAzOjQxOjA5IDIwMDENCkBAIC04 OCw2ICs4OCw4IEBADQogDQogI2RlZmluZQkJQVJHU1RSCQkJIkRhbG54Ig0K IA0KKyNkZWZpbmUgZmRfaG93bWFueSh4LCB5KSAgICAgICAgKCgoeCkgKyAo KHkpIC0gMSkpIC8gKHkpKQ0KKw0KIC8qIHdyYXBwZXIgZm9yIEtBTUUtc3Bl Y2lhbCBnZXRuYW1laW5mbygpICovDQogI2lmbmRlZiBOSV9XSVRIU0NPUEVJ RA0KICNkZWZpbmUJTklfV0lUSFNDT1BFSUQJMA0KQEAgLTM4Myw3ICszODUs NyBAQA0KIAlpbnQgcGNjID0gMCwgZmNjID0gMDsNCiAJaW50IGNjLCBuZmQs IG47DQogCWNoYXIgY250bDsNCi0JZmRfc2V0IGliaXRzLCBvYml0cywgZWJp dHMsICpvbWFzazsNCisJZmRfc2V0ICppYml0cywgKm9iaXRzLCAqZWJpdHMs ICpvbWFzazsNCiAJcmVnaXN0ZXIgY2hhciAqY3A7DQogCWludCBsZWZ0LCBt Ow0KIA0KQEAgLTQwNCw0NiArNDA2LDY3IEBADQogCX0NCiANCiAJZm9yICg7 Oykgew0KLQkJRkRfWkVSTygmZWJpdHMpOw0KLQkJRkRfWkVSTygmaWJpdHMp Ow0KLQkJRkRfWkVSTygmb2JpdHMpOw0KKwkJaWJpdHMgPSBjYWxsb2MoZmRf aG93bWFueShuZmQsIE5GREJJVFMpLCBzaXplb2YoZmRfbWFzaykpOw0KKwkJ aWYgKGliaXRzID09IE5VTEwpDQorCQkJZmF0YWwoZiwgImNhbGxvYyIsIDEp Ow0KKwkJDQorCQlvYml0cyA9IGNhbGxvYyhmZF9ob3dtYW55KG5mZCwgTkZE QklUUyksIHNpemVvZihmZF9tYXNrKSk7DQorCQlpZiAob2JpdHMgPT0gTlVM TCkgew0KKwkJCWZyZWUoaWJpdHMpOw0KKwkJCWZhdGFsKGYsICJjYWxsb2Mi LCAxKTsNCisJCX0NCisJDQorCQllYml0cyA9IGNhbGxvYyhmZF9ob3dtYW55 KG5mZCwgTkZEQklUUyksIHNpemVvZihmZF9tYXNrKSk7DQorCQlpZiAoZWJp dHMgPT0gTlVMTCkgew0KKwkJCWZyZWUob2JpdHMpOw0KKwkJCWZyZWUoaWJp dHMpOw0KKwkJCWZhdGFsKGYsICJjYWxsb2MiLCAxKTsNCisJCX0NCisNCiAJ CW9tYXNrID0gTlVMTDsNCisNCiAJCWlmIChmY2MpIHsNCi0JCQlGRF9TRVQo cCwgJm9iaXRzKTsNCi0JCQlvbWFzayA9ICZvYml0czsNCisJCQlGRF9TRVQo cCwgb2JpdHMpOw0KKwkJCW9tYXNrID0gb2JpdHM7DQogCQl9IGVsc2UNCi0J CQlGRF9TRVQoZiwgJmliaXRzKTsNCisJCQlGRF9TRVQoZiwgaWJpdHMpOw0K IAkJaWYgKHBjYyA+PSAwKSB7DQogCQkJaWYgKHBjYykgew0KLQkJCQlGRF9T RVQoZiwgJm9iaXRzKTsNCi0JCQkJb21hc2sgPSAmb2JpdHM7DQorCQkJCUZE X1NFVChmLCBvYml0cyk7DQorCQkJCW9tYXNrID0gb2JpdHM7DQogCQkJfSBl bHNlDQotCQkJCUZEX1NFVChwLCAmaWJpdHMpOw0KKwkJCQlGRF9TRVQocCwg aWJpdHMpOw0KIAkJfQ0KLQkJRkRfU0VUKHAsICZlYml0cyk7DQotCQlpZiAo KG4gPSBzZWxlY3QobmZkLCAmaWJpdHMsIG9tYXNrLCAmZWJpdHMsIDApKSA8 IDApIHsNCisJCUZEX1NFVChwLCBlYml0cyk7DQorCQlpZiAoKG4gPSBzZWxl Y3QobmZkLCBpYml0cywgb21hc2ssIGViaXRzLCAwKSkgPCAwKSB7DQorCQkJ ZnJlZShpYml0cyk7DQorCQkJZnJlZShvYml0cyk7DQorCQkJZnJlZShlYml0 cyk7DQogCQkJaWYgKGVycm5vID09IEVJTlRSKQ0KIAkJCQljb250aW51ZTsN CiAJCQlmYXRhbChmLCAic2VsZWN0IiwgMSk7DQogCQl9DQogCQlpZiAobiA9 PSAwKSB7DQogCQkJLyogc2hvdWxkbid0IGhhcHBlbi4uLiAqLw0KKwkJCWZy ZWUoaWJpdHMpOw0KKwkJCWZyZWUob2JpdHMpOw0KKwkJCWZyZWUoZWJpdHMp Ow0KIAkJCXNsZWVwKDUpOw0KIAkJCWNvbnRpbnVlOw0KIAkJfQ0KICNkZWZp bmUJcGtjb250cm9sKGMpCSgoYykmKFRJT0NQS1RfRkxVU0hXUklURXxUSU9D UEtUX05PU1RPUHxUSU9DUEtUX0RPU1RPUCkpDQotCQlpZiAoRkRfSVNTRVQo cCwgJmViaXRzKSkgew0KKwkJaWYgKEZEX0lTU0VUKHAsIGViaXRzKSkgew0K IAkJCWNjID0gcmVhZChwLCAmY250bCwgMSk7DQogCQkJaWYgKGNjID09IDEg JiYgcGtjb250cm9sKGNudGwpKSB7DQogCQkJCWNudGwgfD0gb29iZGF0YVsw XTsNCiAJCQkJc2VuZChmLCAmY250bCwgMSwgTVNHX09PQik7DQogCQkJCWlm IChjbnRsICYgVElPQ1BLVF9GTFVTSFdSSVRFKSB7DQogCQkJCQlwY2MgPSAw Ow0KLQkJCQkJRkRfQ0xSKHAsICZpYml0cyk7DQorCQkJCQlGRF9DTFIocCwg aWJpdHMpOw0KIAkJCQl9DQogCQkJfQ0KIAkJfQ0KLQkJaWYgKEZEX0lTU0VU KGYsICZpYml0cykpIHsNCisJCWlmIChGRF9JU1NFVChmLCBpYml0cykpIHsN CiAjaWZkZWYJQ1JZUFQNCiAJCQlpZiAoZG9lbmNyeXB0KQ0KIAkJCQlmY2Mg PSBkZXNfZW5jX3JlYWQoZiwgZmlidWYsIHNpemVvZihmaWJ1ZiksDQpAQCAt NDU3LDggKzQ4MCwxMiBAQA0KIAkJCQljcCA9IE5VTEw7DQogCQkJCWxlZnQg PSBtID0gMDsNCiANCi0JCQkJaWYgKGZjYyA8PSAwKQ0KKwkJCQlpZiAoZmNj IDw9IDApIHsNCisJCQkJCWZyZWUoaWJpdHMpOw0KKwkJCQkJZnJlZShvYml0 cyk7DQorCQkJCQlmcmVlKGViaXRzKTsNCiAJCQkJCWJyZWFrOw0KKwkJCQl9 DQogCQkJCWZicCA9IGZpYnVmOw0KIAkJCXRvcDoNCiAJCQkJZm9yIChjcCA9 IGZpYnVmOyBjcCA8IGZpYnVmK2ZjYy0xOyBjcCsrKQ0KQEAgLTQ3NSwxMSAr NTAyLDExIEBADQogCQkJCQkJCWdvdG8gdG9wOyAvKiBuXjIgKi8NCiAJCQkJ CQl9DQogCQkJCQl9DQotCQkJCUZEX1NFVChwLCAmb2JpdHMpOwkJLyogdHJ5 IHdyaXRlICovDQorCQkJCUZEX1NFVChwLCBvYml0cyk7CQkvKiB0cnkgd3Jp dGUgKi8NCiAJCQl9DQogCQl9DQogDQotCQlpZiAoRkRfSVNTRVQocCwgJm9i aXRzKSAmJiBmY2MgPiAwKSB7DQorCQlpZiAoRkRfSVNTRVQocCwgb2JpdHMp ICYmIGZjYyA+IDApIHsNCiAJCQljYyA9IHdyaXRlKHAsIGZicCwgZmNjKTsN CiAJCQlpZiAoY2MgPiAwKSB7DQogCQkJCWZjYyAtPSBjYzsNCkBAIC00ODcs NyArNTE0LDcgQEANCiAJCQl9DQogCQl9DQogDQotCQlpZiAoRkRfSVNTRVQo cCwgJmliaXRzKSkgew0KKwkJaWYgKEZEX0lTU0VUKHAsIGliaXRzKSkgew0K IAkJCXBjYyA9IHJlYWQocCwgcGlidWYsIHNpemVvZihwaWJ1ZikpOw0KIAkJ CXBicCA9IHBpYnVmOw0KIAkJCWlmIChwY2MgPCAwICYmIGVycm5vID09IEVX T1VMREJMT0NLKQ0KQEAgLTQ5OSw3ICs1MjYsNyBAQA0KICNpZmRlZglDUllQ VA0KIAkJCQlpZiAoIWRvZW5jcnlwdCkNCiAjZW5kaWYNCi0JCQkJCUZEX1NF VChmLCAmb2JpdHMpOwkvKiB0cnkgd3JpdGUgKi8NCisJCQkJCUZEX1NFVChm LCBvYml0cyk7CS8qIHRyeSB3cml0ZSAqLw0KIAkJCX0gZWxzZSB7DQogCQkJ CWlmIChwa2NvbnRyb2wocGlidWZbMF0pKSB7DQogCQkJCQlwaWJ1ZlswXSB8 PSBvb2JkYXRhWzBdOw0KQEAgLTUwOCw3ICs1MzUsNyBAQA0KIAkJCQlwY2Mg PSAwOw0KIAkJCX0NCiAJCX0NCi0JCWlmICgoRkRfSVNTRVQoZiwgJm9iaXRz KSkgJiYgcGNjID4gMCkgew0KKwkJaWYgKChGRF9JU1NFVChmLCBvYml0cykp ICYmIHBjYyA+IDApIHsNCiAjaWZkZWYJQ1JZUFQNCiAJCQlpZiAoZG9lbmNy eXB0KQ0KIAkJCQljYyA9IGRlc19lbmNfd3JpdGUoZiwgcGJwLCBwY2MsDQpA QCAtNTIyLDggKzU0OSwxMSBAQA0KIAkJCQkgKiBmcm9tIHAsIGJ1dCBzb21l IG9sZCBrZXJuZWxzIGJhbGsgYXQgbGFyZ2UNCiAJCQkJICogd3JpdGVzIGV2 ZW4gd2hlbiBzZWxlY3QgcmV0dXJucyB0cnVlLg0KIAkJCQkgKi8NCi0JCQkJ aWYgKCFGRF9JU1NFVChwLCAmaWJpdHMpKQ0KKwkJCQlpZiAoIUZEX0lTU0VU KHAsIGliaXRzKSkNCiAJCQkJCXNsZWVwKDUpOw0KKwkJCQlmcmVlKGliaXRz KTsNCisJCQkJZnJlZShvYml0cyk7DQorCQkJCWZyZWUoZWJpdHMpOw0KIAkJ CQljb250aW51ZTsNCiAJCQl9DQogCQkJaWYgKGNjID4gMCkgew0K --0-1615358615-1000198011=:47624-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1010911044302.47624A-300000>