From owner-freebsd-audit  Sun Jun 24 15:32:23 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138])
	by hub.freebsd.org (Postfix) with ESMTP id 7500237B406
	for <audit@FreeBSD.org>; Sun, 24 Jun 2001 15:32:20 -0700 (PDT)
	(envelope-from dima@unixfreak.org)
Received: from hornet.unixfreak.org (hornet [63.198.170.140])
	by bazooka.unixfreak.org (Postfix) with ESMTP
	id 7FB2C3E28; Sun, 24 Jun 2001 15:32:19 -0700 (PDT)
To: Mike Heffner <mheffner@vt.edu>
Cc: Mike Barcroft <mike@q9media.com>, audit@FreeBSD.org
Subject: Re: src/usr.sbin/zic patch 
In-Reply-To: <XFMail.20010624221124.mheffner@novacoxmail.com>; from mheffner@novacoxmail.com on "Sun, 24 Jun 2001 22:11:24 -0400 (EDT)"
Date: Sun, 24 Jun 2001 15:32:19 -0700
From: Dima Dorfman <dima@unixfreak.org>
Message-Id: <20010624223219.7FB2C3E28@bazooka.unixfreak.org>
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

Mike Heffner <mheffner@novacoxmail.com> writes:
> 
> On 23-Jun-2001 Mike Barcroft wrote:
> | I would appreciate it if someone would commit the patch at the end of
> | this message.  Also available at:
> | http://testbed.q9media.net/freebsd/zic.20010623.patch
> ...
> | 
> | Index: zic/private.h
> | ===================================================================
> | RCS file: /home/ncvs/src/usr.sbin/zic/private.h,v
> | retrieving revision 1.4
> | diff -u -r1.4 private.h
> | --- zic/private.h     2000/11/28 18:18:56     1.4
> | +++ zic/private.h     2001/06/23 22:19:53
> | @@ -99,7 +99,7 @@
> |  void *       irealloc P((void * pointer, int size));
> |  void icfree P((char * pointer));
> |  void ifree P((char * pointer));
> | -char *       scheck P((const char *string, const char *format));
> | +const char * scheck P((const char *string, const char *format));
> 
> I believe `__const' should be used to not break K&R. Same goes for the
> definition.

Just `const' is fine since it can be defined away (e.g., cc -Dconst=).
See message-id
<Pine.BSF.4.21.0106041245240.53715-100000@besplex.bde.org> for
comments from bde@ on this subject.

> 
> 
> Mike
> 
> -- 
>   Mike Heffner         <mheffner@[acm.]vt.edu>
>   Fredericksburg, VA       <mikeh@FreeBSD.org>
> 
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-audit" in the body of the message
> 

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message