From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Feb 1 00:50:02 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6CDB7106575F for ; Sun, 1 Feb 2009 00:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2E3EF8FC16 for ; Sun, 1 Feb 2009 00:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n110o2SH079733 for ; Sun, 1 Feb 2009 00:50:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n110o2ZN079732; Sun, 1 Feb 2009 00:50:02 GMT (envelope-from gnats) Resent-Date: Sun, 1 Feb 2009 00:50:02 GMT Resent-Message-Id: <200902010050.n110o2ZN079732@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Gerald Pfeifer Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 272641065694; Sun, 1 Feb 2009 00:41:37 +0000 (UTC) (envelope-from pfeifer@sputnik1.dbai.tuwien.ac.at) Received: from sputnik1.dbai.tuwien.ac.at (sputnik1.dbai.tuwien.ac.at [128.131.111.141]) by mx1.freebsd.org (Postfix) with ESMTP id B20958FC25; Sun, 1 Feb 2009 00:41:36 +0000 (UTC) (envelope-from pfeifer@sputnik1.dbai.tuwien.ac.at) Received: from sputnik1.dbai.tuwien.ac.at (localhost [127.0.0.1]) by sputnik1.dbai.tuwien.ac.at (8.14.3/8.14.3) with ESMTP id n110fYXG096549; Sun, 1 Feb 2009 01:41:34 +0100 (CET) (envelope-from pfeifer@sputnik1.dbai.tuwien.ac.at) Received: (from pfeifer@localhost) by sputnik1.dbai.tuwien.ac.at (8.14.3/8.14.3/Submit) id n110fYC6096548; Sun, 1 Feb 2009 01:41:34 +0100 (CET) (envelope-from pfeifer) Message-Id: <200902010041.n110fYC6096548@sputnik1.dbai.tuwien.ac.at> Date: Sun, 1 Feb 2009 01:41:34 +0100 (CET) From: Gerald Pfeifer To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/131235: portlint: warn about COMMENT?= like we do for others X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Feb 2009 00:50:02 -0000 >Number: 131235 >Category: ports >Synopsis: portlint: warn about COMMENT?= like we do for others >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Feb 01 00:50:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Gerald Pfeifer >Release: FreeBSD 7.1-RELEASE i386 >Organization: >Environment: System: FreeBSD sputnik1.dbai.tuwien.ac.at 7.1-RELEASE FreeBSD 7.1-RELEASE #0: Thu Jan 1 14:37:25 UTC 2009 root@logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: In case of COMMENT and other field we already warn that ?= only should be used for master ports; we missed to do so for the MAINTAINER field. >How-To-Repeat: >Fix: Suggested patch below, tested against lang/gcc34 before adjusting it. --- /usr/local/bin/portlint 2009-01-31 12:51:17.000000000 +0100 +++ portlint 2009-02-01 01:29:40.723187000 +0100 @@ -2523,8 +2523,12 @@ )); $tmp = "\n" . $tmp; - if ($tmp =~ /\nMAINTAINER\??=([^\n]+)/) { - my $addr = $1; + if ($tmp =~ /\nMAINTAINER(\?)?=([^\n]+)/) { + if ($1 ne '') { + &perror("WARN", $file, -1, "unless this is a master port, MAINTAINER has to be set by \"=\", ". + "not by \"$1=\".") unless ($masterport); + } + my $addr = $2; $addr =~ s/^\s*//; $addr =~ s/\s*$//; if ($addr =~ /[\s,<>()]/) { >Release-Note: >Audit-Trail: >Unformatted: