Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 9 Sep 2014 14:47:34 +0400
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        Luigi Rizzo <rizzo@iet.unipi.it>
Cc:        "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>
Subject:   Re: svn commit: r270874 - in head/sys: dev/netmap net
Message-ID:  <20140909104734.GD17059@FreeBSD.org>
In-Reply-To: <CA%2BhQ2%2BjEZxpDwPdpJkPTbOu1UDXZz6jesB189rACWWy3CceBCA@mail.gmail.com>
References:  <201408311133.s7VBXJlv084881@svn.freebsd.org> <CA%2BhQ2%2BjEZxpDwPdpJkPTbOu1UDXZz6jesB189rACWWy3CceBCA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
  Luigi,

On Mon, Sep 08, 2014 at 01:18:44PM +0200, Luigi Rizzo wrote:
L> I would appreciate if you and others could inform me _before_ touching
L> netmap-related stuff, and also, if you make changes make sure they are
L> visible to the preprocessor so i can use conditional compilations.
L> 
L> This is because this code is supposed to be the same on various FreeBSD
L> revisions
L> and Linux, and if each platform randomly changes its structures maintainance
L> becomes very hard

The patch was checked in to fix compilation failure, thus review was skipped.

Does the patch itself have any problems with visibility to preprocessor?

-- 
Totus tuus, Glebius.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140909104734.GD17059>