Date: Tue, 18 Jul 2006 10:23:19 -0600 From: Scott Long <scottl@samsco.org> To: Paolo Pisati <piso@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 101845 for review Message-ID: <44BD0AF7.8030408@samsco.org> In-Reply-To: <200607181107.k6IB7Vf1040641@repoman.freebsd.org> References: <200607181107.k6IB7Vf1040641@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Paolo Pisati wrote: > http://perforce.freebsd.org/chv.cgi?CH=101845 > > Change 101845 by piso@piso_newluxor on 2006/07/18 11:07:29 > > Defining an interrupt handler as INTR_FAST means > the interrupt thread associated to this interrupt event > won't be created: actually with filter+ithread, we need > that thread. > > Affected files ... > > .. //depot/projects/soc2006/intr_filter/dev/em/if_em.c#7 edit > > Differences ... > > ==== //depot/projects/soc2006/intr_filter/dev/em/if_em.c#7 (text+ko) ==== > > @@ -1986,7 +1986,7 @@ > */ > TASK_INIT(&sc->link_task, 0, em_handle_link, sc); > if ((error = bus_setup_intr(dev, sc->res_interrupt, > - INTR_TYPE_NET | INTR_FAST, em_intr_fast, em_handle_rxtx, sc, > + INTR_TYPE_NET, em_intr_fast, em_handle_rxtx, sc, > &sc->int_handler_tag)) != 0) { > device_printf(dev, "Failed to register fast interrupt " > "handler: %d\n", error); Now you've made if_em no longer be MPSAFE. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44BD0AF7.8030408>