Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Jun 2020 15:28:41 +0200
From:      Mathieu Arnold <mat@freebsd.org>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        Fernando Apestegu??a <fernape@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r540489 - in head/devel/fhist: . files
Message-ID:  <20200626132841.kytmjwquonpwkrhr@aching.in.mat.cc>
In-Reply-To: <20200626124105.GA65385@FreeBSD.org>
References:  <202006261034.05QAYaDe038059@repo.freebsd.org> <20200626124105.GA65385@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--fq3my2lrxbkpfplh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 26, 2020 at 12:41:05PM +0000, Alexey Dokuchaev wrote:
> On Fri, Jun 26, 2020 at 10:34:36AM +0000, Fernando Apestegu??a wrote:
> > New Revision: 540489
> > URL: https://svnweb.freebsd.org/changeset/ports/540489
> >=20
> > Log:
> >   devel/fhist: and fix bison issues and change maintership
> >=20
> > Modified:
> >   head/devel/fhist/Makefile
> >   head/devel/fhist/files/patch-common_ac_time.h
> >=20
> > Modified: head/devel/fhist/files/patch-common_ac_time.h
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- head/devel/fhist/files/patch-common_ac_time.h	Fri Jun 26 09:35:06 2=
020	(r540488)
> > +++ head/devel/fhist/files/patch-common_ac_time.h	Fri Jun 26 10:34:36 2=
020	(r540489)
> > @@ -1,6 +1,6 @@
> > ---- common/ac/time.h.orig	Wed Dec 18 02:09:57 2002
> > -+++ common/ac/time.h	Wed Dec 18 02:10:04 2002
> > -@@ -29,7 +29,7 @@
> > +--- common/ac/time.h.orig	2012-07-13 04:47:15 UTC
> > ++++ common/ac/time.h
> > +@@ -26,7 +26,7 @@
> >    * Catch-22: Dec Alpha OSF/1: need to include time.h before sys/time.h
> >    * before time.h
> >    */
>=20
> Please, "svn revert" patches which forwent no functional changes prior
> to making commit.  It just clutters the diff and decreases SNR. :-(

In that particular case, it was correct to commit the patch, it has
functional change, the range information changed, and it is definitively
not just noise.

--=20
Mathieu Arnold

--fq3my2lrxbkpfplh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAl71+ARfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2
MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd
fgIRaQ//Ze3gw1rySpHWO92jfEAXVS/aR9F+51sAkOcfTjRq8fvOEVtrYXR6GjOB
9If1Vkeco1hw/zWcO2ZER0WiTepxLvVOCVfL1qQSJnDZNu6dSKmEVdR59LCplm4c
a0z9t9upbRRfcZkcyI46WodXSkDjV17tsIIAnnzE8WPHS6nfi7BKm6kHFH8RAGpf
hVQLgj6Q6lhPDFvMOwgNwiWQja2XRYqDRtNVv/LkLokUaevIkVdvMun/vXRmk2k0
J+vMc3xTYHuGRwhdMpvk78wZ62SXt7MmlqTg/1BHRTbVLusl2AfrnqQg5ZTjhgOF
/JCG6s5GGUn53aoyKwfGejCKgS2/BR6YrEHcYGbh4KkwiUDiDN66MG9r1cg+J+Ea
nc+do+lg0bkOMj/0x6VKHmzACclkwiMWNgECOKvIf1k9/dtWjWqBpFfeIHb+juwq
RG8Ez8YkjTmoguDDKniBrsJ6SpXlPbVioCA3SR2TVtIzEpJaNVMVjdrchQi81TeZ
A2btT/dPNKHtwp6cllSwT4fOJ/Hm2eX1c7OYOLk56gbziFAg3GdXCYLuLRjxoeT/
XDyrxq1FUx7IwaP/ZKj84qRDnuVibP65yJRXhZONmQPFAXjsjsscxOUbzEVG4xTd
Tr+XWc2OOq2O7JwnUliRI/y8gMviwNllSGwaJeb3oUtKAvqlF6c=
=KA94
-----END PGP SIGNATURE-----

--fq3my2lrxbkpfplh--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200626132841.kytmjwquonpwkrhr>