From owner-svn-src-projects@freebsd.org  Thu Aug 13 06:43:57 2015
Return-Path: <owner-svn-src-projects@freebsd.org>
Delivered-To: svn-src-projects@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E07EF9A0BE9
 for <svn-src-projects@mailman.ysv.freebsd.org>;
 Thu, 13 Aug 2015 06:43:57 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au
 [211.29.132.249])
 by mx1.freebsd.org (Postfix) with ESMTP id 49B5FA2B;
 Thu, 13 Aug 2015 06:43:57 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from c211-30-166-197.carlnfd1.nsw.optusnet.com.au
 (c211-30-166-197.carlnfd1.nsw.optusnet.com.au [211.30.166.197])
 by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id A4B541043192;
 Thu, 13 Aug 2015 16:43:47 +1000 (AEST)
Date: Thu, 13 Aug 2015 16:43:47 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Baptiste Daroussin <bapt@freebsd.org>
cc: Bruce Evans <brde@optusnet.com.au>, Bruce Simpson <bms@fastmail.net>, 
 Davide Italiano <davide@freebsd.org>, 
 "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 svn-src-projects@freebsd.org
Subject: Re: svn commit: r286484 - projects/collation/usr.bin/localedef
In-Reply-To: <20150813061802.GA62875@ivaldir.etoilebsd.net>
Message-ID: <20150813162711.U1840@besplex.bde.org>
References: <201508082257.t78MvIT1000841@repo.freebsd.org>
 <CACYV=-GnOpPddd-x_J0yW4g4QFsdcEVXaVc9CER9JD7iObGzAg@mail.gmail.com>
 <20150812182739.GB51754@ivaldir.etoilebsd.net> <55CB91FD.8000004@fastmail.net>
 <20150813114425.X996@besplex.bde.org>
 <20150813061802.GA62875@ivaldir.etoilebsd.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.1 cv=XMDNMlVE c=1 sm=1 tr=0
 a=KA6XNC2GZCFrdESI5ZmdjQ==:117 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8
 a=kj9zAlcOel0A:10 a=vr2PWWN7zcCx54ctziMA:9 a=CjuIK1q_8ugA:10
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Aug 2015 06:43:58 -0000

On Thu, 13 Aug 2015, Baptiste Daroussin wrote:

> On Thu, Aug 13, 2015 at 12:16:41PM +1000, Bruce Evans wrote:
>> On Wed, 12 Aug 2015, Bruce Simpson wrote:
>>>>> ...
>>>>> Can you commit this one to HEAD && move it to the right header?
>>
>> This has too many bugs to commit.
>
> FYI the version proposed for tree(3):
>
> #define RB_COUNT(x, name, head, cnt) do {	\
> 	(cnt) = 0;				\
> 	RB_FOREACH((x), name, (head)) {		\
> 		(cnt)++;			\
> 	}					\
> } while (0)

Now it is bug for bug consistent with tree.h in using a space instead of
a tab after #define (tree.h is inconsistent with itself for only 5 out
of 82 #define's).

It doesn't line up the backslashe the same.  tree.h consistently lines
them up in column 72 whenever possible.

It adds 1 more inconsistency for the do-while(0) hack.  tree.h uses
/*CONSTCOND*/ lint markup for 10 of 11 instances.  This is too ugly
for me, but it is the existing style.

Bruce